Comments (15)
I did not understand this. Why do we need this?
from galois.
It is a little unexpected that USE_ARCH
is completely ignored if ENABLE_HETERO_GALOIS=ON
since those two options are not related to each other for CPU code.
https://github.com/IntelligentSoftwareSystems/Galois/blob/master/CMakeLists.txt#L69
from galois.
Yah, it's an unexpected behavior issue. I'm not aware of anything that makes this urgent. The current behavior is just weird.
from galois.
What is USE_ARCH expected to do?
I will be renaming ENABLE_HETERO_GALOIS to GALOIS_ENABLE_GPU (and merging it with USE_GPU). That flag will enable single/distributed GPU code for lonestar (analytics/mining/scientific).
from galois.
USE_ARCH sets the appropriate -march=...
flag for the CPU code.
from galois.
I don't see USE_ARCH being used anywhere currently. It was being used for KNL if I remember right. But where is that code in our cmake files?
https://github.com/IntelligentSoftwareSystems/Galois/blob/master/CMakeLists.txt#L69
I will drop those lines. They are not related/required.
from galois.
It's in https://github.com/IntelligentSoftwareSystems/Galois/blob/master/cmake/Modules/CheckArchFlags.cmake which defined variables that then get pulled in here: https://github.com/IntelligentSoftwareSystems/Galois/blob/master/CMakeLists.txt#L132.
from galois.
My best guess is that the if statement at https://github.com/IntelligentSoftwareSystems/Galois/blob/master/CMakeLists.txt#L69 was added to work around some kind of compiler error for the heterogeneous case. @ddn0, you added that, do you remember why it's there?
from galois.
Thanks, Ian. This is not related to GALOIS_ENABLE_GPU flag, so waiting for Donald's reply to see if he added those lines.
from galois.
I added that line to follow the original logic:
68df52e#diff-af3b638bc2a3e6c650974192a53c7291L139
which was added in this commit:
bc691fe
That's where my context ends :D
Unrelated to this issue, I noticed there are still quite a few warnings when compiling gluon (unused parameters) and with gcc 8.4/clang 9, I actually get an internal compiler error:
[ 77%] Building CUDA object lonestar/analytics/gpu/pta/CMakeFiles/pta_gpu.dir/pta.cu.o
...
/home/ddn/w/katana/lonestar/analytics/gpu/pta/andersen.cu(1379): internal error: assertion failed: conv_glvalue_expr_to_prvalue: bad expr (/dvs/p4/build/sw/rel/gpu_drv/r418/TRD418_98/drivers/compiler/edg/EDG_5.0/src/exprutil.c, line 20215)
1 catastrophic error detected in the compilation of "/tmp/tmpxft_00004683_00000000-4_pta.cpp4.ii".
ddn@spork:katana-build$ nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2019 NVIDIA Corporation
Built on Wed_Apr_24_19:10:27_PDT_2019
Cuda compilation tools, release 10.1, V10.1.168
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 13a2e9376..91ed1a9e8 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -66,9 +66,9 @@ if(NUM_TEST_THREADS LESS_EQUAL 0)
set(NUM_TEST_THREADS 1)
endif()
-if(ENABLE_HETERO_GALOIS)
- set(USE_ARCH none)
-endif()
+# if(ENABLE_HETERO_GALOIS)
+# set(USE_ARCH none)
+# endif()
###### Configure (users don't need to go beyond here) ######
@@ -93,7 +93,7 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
message(FATAL_ERROR "gcc must be version 7 or higher. Found ${CMAKE_CXX_COMPILER_VERSION}.")
endif()
- add_compile_options("$<$<COMPILE_LANGUAGE:CXX>:-Wall;-Wextra;-Werror>")
+ add_compile_options("$<$<COMPILE_LANGUAGE:CXX>:-Wall;-Wextra;-Werror;-w>")
if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 9)
# Avoid warnings from openmpi
from galois.
which was added in this commit:
bc691fe
Thanks, Donald. This was my commit but those lines were there from a commit before that. It's pretty old. I don't think it's needed.
from galois.
Unrelated to this issue, I noticed there are still quite a few warnings when compiling gluon (unused parameters) and with gcc 8.4/clang 9, I actually get an internal compiler error:
Are these errors related to commenting out those lines?
"analytics/gpu" is not gluon code. Please raise an issue and assign it to Vishwesh.
If there are still warning on analytics/distributed related to GPU code, please raise an issue for that and assign it to Vishwesh and me.
from galois.
Are these errors related to commenting out those lines?
"analytics/gpu" is not gluon code. Please raise an issue and assign it to Vishwesh.
If there are still warning on analytics/distributed related to GPU code, please raise an issue for that and assign it to Vishwesh and me.
There are two issues:
- warnings in gluon
- ICE in analytics/gpu
I'll file issues for both.
from galois.
Thanks!
from galois.
I made those flags independent in PR 199.
from galois.
Related Issues (20)
- Compilation Problems HOT 2
- Question about sssp-pull.cpp HOT 1
- What is the format of mastersFile? HOT 1
- How to add new code to Galois and modify the Makefile HOT 2
- Question of the MPI Network Layer (is the order guaranteed for the message?) HOT 6
- BFS hangs HOT 1
- Compiling Galois HOT 1
- Installation error HOT 1
- did you forget to ‘#include <optional>’? HOT 2
- Performance degradation for distributed PageRank HOT 8
- Is this project still alive? HOT 1
- papiGetTID error HOT 1
- Cmake error HOT 1
- "endian.h" file not found error while building BFS Application
- conversion undefined for void graphs HOT 1
- Cannot seem to get correct results for Connected Components
- Where is the directory of your HyperNetVec's implementation in corresponding paper?
- Does it support running on mac with m series chips
- Did this framework support SIMD instruction for parallelization?
- The server with the inputs requires a secured https connection
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from galois.