Comments (6)
@n-huber try turning off the FSP sharing coreboot stack
from fsp.
Hi @n-huber,
We recently ran into this while working on TianoCore open source firmware actually. It fix it, we had to increase the size of the bootloader stack. Please see Prince's patch: https://edk2.groups.io/g/devel/message/52138
I think the 256KB is probably overkill, but it illustrates how to resolve the issue.
Edit: I talked to Prince and he mentioned that 256KB seems to be required.
from fsp.
@jackpot51 thanks, but it's disabled by default. Seems to be part of the problem, though.
@nate-desimone Did you just switch to FSP 2.1 without notice??? Please update the documentation in case. I guess we can perform that switch for upstream coreboot. But what does Intel expect customers to do? Such a big switch late in a product cycle, plus all its legal concerns (remember coreboot is a GPL project, and Intel refuses to research compatibility).
from fsp.
I can confirm that it's working with increased coreboot stack and decreased heap size (config FSP_USES_CB_STACK). Please keep this issue open until all related documentation is fixed!
from fsp.
@n-huber, no we did not switch CFL to FSP 2.1. We did implement the single stack feature from 2.1 in later versions of CFL FSP, but none of the bigger features like dispatch mode were ported.
from fsp.
@n-huber, I have updated the Coffee Lake FSP Integration Guide as of eb25f19 to explicitly document this. Note the following except from section 3.6.2:
Starting with version 7.0.65.50 and later, this FSP will run on top of the stack provided by the bootloader instead of establishing a separate stack. This feature was adopted from the v2.1 FSP specification, however none of the other features described in v2.1 are implemented.
from fsp.
Related Issues (20)
- UPD CaVrefConfig missing on TGL HOT 1
- Is FSP broken with SPI TPM? HOT 1
- GLK - FSP M configuration HOT 6
- Missing Documentation: TGL DdrMemoryDown
- The "Failed to get GFX HOB from FSP" SBL debug log show at TGL Up3.
- SMBIOS memory information missing on Denverton HOT 1
- #include <FspEas.h> undocumented HOT 1
- Alder Lake S IOT FSP package has missing headers HOT 4
- Rocket Lake FSP support HOT 5
- FSP spec: debug registers HOT 1
- ApolloLake FSP MR10 problem (PreMemSa)
- TGL_IOT FSP missing `FirmwareVersionInfoHob.h` header HOT 1
- error: ‘FspPcdListLibNull’ defined but not used HOT 1
- ElkhartLake MR5 VBT BSF file is not correct HOT 2
- Raptor Lake-S (LGA 1700) FSP support HOT 1
- Tiger Lake IOT FSP files contain "Intel Confidential" in license headers HOT 1
- Alderlake N is missing MemInfoHob.h HOT 1
- Alder Lake N is missing FirmwareVersionInfoHob.h HOT 4
- Sapphire Rapids FSP HOT 3
- Raptor Lake Refresh-S (LGA 1700) FSP support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fsp.