Comments (5)
Defaulting to explicit merges gives contributors space to build a change out of several small pivots, and explain each pivot in a distinct commit message. That's likely easier to review, both when the pull is in-flight and post-merge if later developers are looking at git blame ...
and trying to figure out what the original developer was thinking.
Building a series of fixups while a pull request is in-flight might make multiple rounds of review easier for a single reviewer who comes back to the same pull for each round of review, and that's great if the contributor and reviewer want to work like that. But the contributor can squash their commits themselves, once the reviewer is happy, into a series of semantic commits or a single commit or whatever they think makes the story most clearly to the hypothetical future developers.
For contributors who are not comfortable doing their own rebase (e.g. a lack of familiarity or access to command-line Git), I think squash-merges make sense. But those can be one-off actions by maintainers reviewing those pulls. It seems unlikely that this style of contribution is frequent enough for it to need to be the default.
from dev-docs.
Maybe a new doc docs/common-github-repo-settings.md
where we can add notes on things we think should be common across all (or most) repos.
from dev-docs.
@russellb I will work on creating something like this week!
from dev-docs.
It seems unlikely that this style of contribution is frequent enough for it to need to be the default.
Anywhere this is a regular thing just means we need some more senior folks to provide some assistance and coaching on how to do all the things you described: crafting a patch series, the use of git rebase
for squashing, ...
from dev-docs.
@wking @russellb I've opened a Pull Request for this issue, let's continue the discussion there: #10
from dev-docs.
Related Issues (20)
- Create policy for uploading Merlinite/Granite models to HuggingFace
- Create policy for consistent label/board usage in the org HOT 1
- Create a policy for deleting PRs that disclose sensitive content HOT 4
- Create automation for syncing common CI/test files HOT 4
- Transfer tiran/instructlab-quantize to instructlab org HOT 15
- Update InstructLab organization's Settings->Actions->General to limit action usage HOT 6
- need recommendations for trusted data sources beyond Wikipedia for Knowledge submissions HOT 16
- Feature Request: Support system-style questions (transferred from Taxonomy) HOT 4
- Update publishing strategy to include ollama publishing
- Create proposal for new evaluation library repo
- Define policy for adding or updating Python dependencies HOT 6
- Create targets in makefile to automatically install the pyspelling dependency if it doesn't exist HOT 10
- Add spelling ignore HOT 1
- add autofix lint errors command in makefile
- Make Governance section examples less vague HOT 3
- Create proposal for PyPI organization HOT 2
- Changes to CLI commands HOT 1
- Proposal to introduce data processor before training the LLM model HOT 5
- Formalize InstructLab Change and Enhancement proposals (ICE) HOT 1
- Draft document detailing release procedures for new libraries
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dev-docs.