Feature: support customized ErrorPage about hyperview HOT 5 CLOSED

Hi @terryatgithub . Yes, we have considered adding custom error page support. We want to implement the error page as a custom React component that gets passed to HyperScreen as a prop. Then, the code from your screenshot would look like this:

render() {
  if (this.state.error) {
    const errorScreen = this.props.errorScreen || LoadError;
    return React.createElement(errorScreen, {
      error: this.state.error,
      onPressReload: () => this.reload(),
      onPressViewDetails: (uri) => this.props.openModal({url: uri})
    });
  }
}

And entrypoint to Hyperview would look like this:

    return (
      <Hyperview
        back={this.goBack}
        closeModal={this.closeModal}
        entrypointUrl={entrypointUrl}
        fetch={this.fetchWrapper}
        navigate={this.navigate}
        navigation={navigation}
        openModal={this.openModal}
        push={this.push}
        formatDate={this.formatDate}
        errorScreen={MyCustomErrorScreen}
      />
    );

@terryatgithub would this solve your issue?

from hyperview.

@flochtililoch what do you think of this approach?

from hyperview.

hi @adamstep , this is a good way.
We want to implement the error page as a custom React component that gets passed to HyperScreen as a prop.

When I tried to implement the function, an idea came to mind , will below method work ?
implement the error page as a xml file, that located in server. and get passed to Hypersceen as a prop
so that the xml error page can be updated anytime.

and also the same question:
do you have a specific schedule about it?
thank you so much.

from hyperview.

When I tried to implement the function, an idea came to mind , will below method work ?
implement the error page as a xml file, that located in server. and get passed to Hypersceen as a prop
so that the xml error page can be updated anytime.

I did consider this approach. However, the error page appears when there's no Internet connection. So the content of the screen can't require an HTTP request.

It's a fairly simple change, we can try to have it ready this week.

from hyperview.

yes, when I tried this approach, I thought maybe

1. a backup error xml version can be storaged in client locally. and only show when no Internet connection. and it will get updated when client has new release.
2. and will request the latest error page in server when internet connection is ok.
   above all, this is just a possible hypothesis for your reference.

and this schedule is exciting, thank you so much.
It's a fairly simple change, we can try to have it ready this week.

from hyperview.