aiohttp middleware returns None if handler raises about python-sensor HOT 7 CLOSED

Hi @ddegirmenci thanks for pointing this out. Let me take a looks and see if I can release a fix soon.

from python-sensor.

Additionally, the init_with_instana function places the middleware at the end of the list, which means that any extra processing (changing status codes, anything that could cause increased response time etc.) will be left out of monitoring -- if I understand everything correctly. Either making sure the middleware is the first in that order, or utilizing another mechanism (signals?) could help with that.

from python-sensor.

That's a good point. We usually put ourselves first in the list for other frameworks and languages. I'll add this in to the improvements.

from python-sensor.

Hi @pglombardo, do you have any news for us? Perhaps a public issue tracker we can follow?

from python-sensor.

Hi @ddegirmenci,

we will update this issue when resolved. We are a bit swamped with end-of-year business :-)

You may also wanna file a ticket under support.instana.com, but frankly that’s optional given that you opened a well-defined issue in GitHub.

Best,
Michele

from python-sensor.

Hey @ddegirmenci if you want to post the same pull request here I'd be happy to merge it.

from python-sensor.

This has been fixed in Instana package 1.17.1.

https://github.com/instana/python-sensor/releases/tag/1.17.1

Thanks for pointing this out!

from python-sensor.