Adapter does not rescue failed connection (PostgreSQL) about makara HOT 7 CLOSED

This is probably surprising behavior but intentional, at least in PG. The issue is the PG adapter calls connect upon instantiation. Since the instantiation of this connection takes place when the adapter is filling the master / slave pools the error is raised early. When the error is raised I do not put the connection in the pool. This means in this scenario you're dealing with 1 master and 0 slaves. So all connections are blacklisted anytime you try to do anything.

I'm thinking the right thing to do is go ahead and place the connection in the pool, but then immediately blacklist it. Thoughts?

from makara.

Yes, that is the desired behavior. Put all database.yml connections in the pool and let makara manage them based on availability.

from makara.

Ah, now I remember going down this road. So the issue is connect() is called from within initialize(). So the object is never returned. You can do Class.allocate but that means the pg makara adapter would have to deal with different configurations and different constructors from different ActiveRecord versions since it would essentially redefine ::ActiveRecord::Base.postgresql_connection().

from makara.

Another possible option is to delay the instantiation by creating an empty wrapper. Then the connection would be instantiated on demand. I'll investigate that as a solution.

from makara.

Ok, here's my first attempt. #35

from makara.

Is there any way to log/see makara activity? eg: add, blacklist, errors

from makara.

Not currently, I'm a bit busy today but will try to add logging tonight.

from makara.