Giter Club home page Giter Club logo

Comments (2)

ruhatch avatar ruhatch commented on May 29, 2024 5

Hi @neongreen!

I agree, in many cases using TH or Generics would decrease the likelihood of bugs, and as an added bonus reduce the amount of code. In this specific case, with a binary serialisation format that might be subject to modification, being explicit means we can add backwards compatibility code to a specific instance or, if something goes wrong, the faulty code is right there for us to see. Also a newcomer to the code will be able to see how something is encoded/decoded without having to -ddump-splices. We do have to be more careful, but this is the code where we'd rather be explicit and careful.

from cardano-ledger-byron.

neongreen avatar neongreen commented on May 29, 2024

as it is better to have hand-written instances for that kind of thing

Well, this is rather questionable. TH was introduced exactly to avoid hard-to-avoid bugs that can occur with hand-written instances.

from cardano-ledger-byron.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.