Comments (3)
- Yes, it currently uses
@import
because it's outdated. So we would have to wait for stencil to upgrade it. I just kinda liked the solution because it's out of the box. - You are right, that it's more transparent. We should do it this way.
from elements.
The variables.scss
in src/components/styles
is a global stylesheet that is loaded before all others. Would it not be sufficient to import the mdc-customize.scss
there? This way we would not have to import it into every file.
If I understand correctly, we could use the injectGlobalPaths of the stencil-sass plugin.
We will have to wait until ionic-team/stencil-sass#38 is resolved or downgrade our stencil version to 1.x.x.
from elements.
I'm not quite sure if this is the proper solution.
-
The global inject script looks like it uses
@import
, but we have to use@use
statements to provide custom variables (see above). -
In my opinion it is more transparent to import our "mdc-customization" module before each "mdc import". It's different from importing variables since it resolves the mdc modules with our custom properties instead of defining variables. Furthermore, components that do not use mdc at all should not import the mdc customization file just for the sake of simplicity.
from elements.
Related Issues (20)
- ino-snackbar: make icon interchangeable
- Storybook: Display colors with new features of storybook
- Storybook: Display typography with new features of storybook
- Upgrade Lerna to newest Version
- Design nice Contributor Cards HOT 1
- Try out Vite in Storybook
- ino-markdown-editor: Make font-sizes configurable
- Storybook<>Landingpage Links dont work
- ino-markdown-editor: Update design
- ino-autocomplete: Selecting same value has no effect
- Add eslint rule to only nest CSS not deeper than 2
- ino-accordion: `max-height` is too low
- ino-list-item: hover & click animation are displayed even in disabled state
- ino-input: Outline variant truncates label after a fixed width
- ui-patterns: Add functionality to patterns
- landingpage: Add tailwind installation hint in our patterns section
- Button Styling checken
- ino-button: Slightly increase border radius to soften corners
- landingpage: version select width collapsed
- ino-icon: Not centered properly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elements.