Giter Club home page Giter Club logo

Comments (6)

aditya-kumawat avatar aditya-kumawat commented on May 25, 2024 1

It throws error as the children type is not string if you are having white-space before/after { and }.
This works:

<Button>{true ? 'a' : 'b' }</Button>

OR

<Button>
   {true ? 'a' : 'b' }
</Button>

from design-system.

Harshit369 avatar Harshit369 commented on May 25, 2024

It throws error as the children type is not string if you are having white-space before/after { and }.
This works:

<Button>{true ? 'a' : 'b' }</Button>

OR

<Button>
   {true ? 'a' : 'b' }
</Button>

But isn't that a catch.. is there a reason we are not allowing React.ReactChildren as children?

from design-system.

Harshit369 avatar Harshit369 commented on May 25, 2024

the design demands a button like this:
image
i was using Custom &nbsp;&nbsp;&nbsp; to suffice for the margin between icon and text? is there a workaround for this that I'm not aware of

from design-system.

aditya-kumawat avatar aditya-kumawat commented on May 25, 2024

Are you using this Button for Dropdown trigger or is it a normal Button?
If it's a normal Button, you need to discuss it with design team that it's not as per design-guidelines.

from design-system.

Harshit369 avatar Harshit369 commented on May 25, 2024

Acts as a trigger for range picker.
image

from design-system.

satyamyadav avatar satyamyadav commented on May 25, 2024

Is resolved by #270

from design-system.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.