`new` subcommand can fail with a type error `string "" is not a function` about themis-contract HOT 5 CLOSED

As you mentioned on #29, this is a direct result of not explicitly specifying the -t mustache parameter. There's unfortunately no easy way for the tool to infer which templating language you want to use.

The makeVariableTrackerProxy function is ultimately a hack (and an ugly one at that), and one that should eventually rather be replaced by proper parsing of the template to expose its variables.

In the meantime, it should suffice to just catch this type of error during the execution of the new command and add a hint to the effect of: (did you perhaps forget to specify the template type?).

from themis-contract.

Perhaps this bit of code in https://github.com/informalsystems/neat-contract/tree/master/src/shared/template-helpers.ts is responsible:

Seems likely to be originating in this function:

const makeVariableTrackerProxy = (parentObj: object, parents: string[], trackedVars: Map<string, any>): object => {
  return new Proxy(parentObj, {
    get: (target, name) => {
      if (typeof name === 'symbol') {
        return ''
      }
      if (name === 'toHTML') {
        return (): string => ''
      }
      const varName = String(name)
      logger.debug(`Found potential template variable: ${varName}`)
      trackVariable(trackedVars, parents, varName)
      return makeVariableTrackerProxy(target, [...parents, varName], trackedVars)
    },
  })
}

Both due to the log locations, and due to the fact this function can return either a string or a function string -> string. At some point, a consumer of the values from this function is getting that empty string out and trying to apply it as a function

from themis-contract.

Cool, I'll add that fix when I get a moment. Thanks!

from themis-contract.

What about changing the default templating language to be mustache too? It seems to me preferable, both because we are using it more pervasively, and because it's more constrained.

from themis-contract.

Sure, let's make Mustache the default 👍 I'll open an issue.

from themis-contract.