govet->fieldalignment - Should we enable it? about telegraf HOT 4 CLOSED

To be honest, with the savings shown I would rather like to keep the "readable" ordering, what do you guys think?

from telegraf.

@srebhan My thoughts exactly.

I'm wondering if we have any performance problems, the solution to which would be to reduce structures by several bytes?
This would also improve (to some extent) the alignment to the CPU cache lines. But still, would such changes noticeably improve anything?

from telegraf.

Wouldn't that actually be a thing for the compiler to optimize? I also prefer the readability of the code.

from telegraf.

@zak-pawel thank you very much for looking through this for us! I tend to agree with previous statements that the benefit does not out weight the cost of keeping the current structure and readability.

Let's go ahead and close this as -1.

from telegraf.