How to show 404 if database/schema doesnt exists? about apartment HOT 11 CLOSED

Thank you guys,
I fixed it with the following code

module Apartment
  module Elevators
    class MySubdomain < Apartment::Elevators::Subdomain
      def call(env)
        request = Rack::Request.new(env)

        database = @processor.call(request)

        begin
          Apartment::Database.switch database if database
        rescue Apartment::DatabaseNotFound, Apartment::SchemaNotFound
          return [404, {"Content-Type" => "text/html"}, ["Not Found"]]
        end

        @app.call(env)
      end
    end
  end
end

from apartment.

hey sorry for the late response... that's basically what we do in our app also.

from apartment.

Please give me advice.

What file should I add the above code to?

from apartment.

@kizashi1122 this can live wherever you want. maybe app/middleware ?? It doesn't matter. Just as long as your module / classname corresponds to Rails autoloading. You could literally do this:

# lib/my_elevator.rb
class MyElevator < Apartment::Elevators::Subdomain
  # ...
end

from apartment.

Thank you. It works fine.

But one more step needed to accomplish it in my case.

1. Put the following file to lib/my_elevator.rb as @bradrobertson mentioned

require 'apartment/elevators/subdomain' # <- this line is necessary
class MyElevator < Apartment::Elevators::Subdomain
  # ...
end

1. Put some code to config/initializers/apartment.rb

require 'my_elevator'
# ...
Rails.application.config.middleware.use 'MyElevator' # instead of 'Apartment::Elevators::Subdomain'

Does it really work without the 2nd step?

Thanks,

from apartment.

no you need both. I was just explaining how to write the middleware.

For future reference this is nothing to do with Apartment itself. It's really just a rails question that could be asked on StackOverflow or something.

from apartment.

Thanks again.
Sorry about that.

But doesn't work with only 1st step. I have to learn Rails more.

I hope this feature will be implemented soon.

from apartment.

http://stackoverflow.com/questions/27188411/apartment-ruby-gem-want-to-catch-an-exception/28233828#28233828 this might help you.

from apartment.

Great help!

from apartment.

// apartment.rb
require 'rescued_apartment_middleware'
...
...
...
Rails.application.config.middleware.insert_before ActiveRecord::Migration::CheckPending, Apartment::Elevators::RescuedApartmentMiddleware

// lib/rescued_apartment_middleware.rb

require 'apartment/elevators/subdomain'
 require 'apartment/tenant'

 module Apartment
  module Elevators
    class RescuedApartmentMiddleware < Apartment::Elevators::Subdomain
      def call(env)
        request = Rack::Request.new(env)
        # @processor is the current middleware instance and the call method will invoke the parse_tenant_name method.
        # if you need to change the subdomain database name you can change it by defining the parse_tenant_name method below
        database = @processor.call(request)
        begin
          Apartment::Tenant.switch!(database) if database
        rescue Apartment::TenantNotFound, ActiveRecord::NoDatabaseError
          Rails.logger.error "Error: Apartment says tenant was not found for #{database.inspect}"
          raise ActionController::RoutingError.new('Not Found')
          #return [404, {"Content-Type" => "text/html"}, ["Not Found"]]
        end
        @app.call(env)
      end
    end
  end
end

// application_controller.rb

 rescue_from Apartment::TenantNotFound do |exception|
    ActionController::RoutingError.new('Not Found')
 end

the above code resolved my issue in Rails 4.2.5

from apartment.

I don't know why rescue is not working, anybody knows?

I had to changed it to:

module Apartment
  module Elevators
    class RescuedApartmentMiddleware < Apartment::Elevators::Subdomain
      def call(env)
        request = Rack::Request.new(env)
        database = @processor.call(request)
        if database
          result = Apartment::Tenant.switch!(database) rescue "notfound"
          if result == "notfound"
            Rails.logger.error "Error: Apartment says tenant was not found for #{database.inspect}"
            raise ActionController::RoutingError.new('Not Found')
          else
            @app.call(env)
          end
        else
          @app.call(env)
        end
      end
    end
  end
end

from apartment.