Giter Club home page Giter Club logo

Comments (8)

mark-nicepants avatar mark-nicepants commented on June 14, 2024

Hmm seems like I now get the message that the ! is required ..

../../../.pub-cache/git/floggy-8e5fca91a4cbbaa20c4dc702b9a88544f0fb3c1c/flutter_loggy/lib/flutter_loggy/stream_printer.dart:16:52: Error: An expression whose value can be 'null' must be null-checked before it can be dereferenced.
    logRecord.add(<LogRecord>[record, ...logRecord.value]);                                              ^

What would be a nice solution for this problem?

from floggy.

lukaknezic avatar lukaknezic commented on June 14, 2024

hmmm, Looking why this can be null and not really sure, only thing that could cause that is if BehaviurSubject is not passing seeded value as last broadcast (that might be a case, seen a few similar bug reported).

So i think easiest fix would be something like:

logRecord.add(<LogRecord>[record, ...logRecord.value ?? <LogRecord>[]]);

Since only way that this value is null is if it's empty.

from floggy.

mark-nicepants avatar mark-nicepants commented on June 14, 2024

I think thats an elegant solution yeah. Would you like me to update the PR with this suggestion?

from floggy.

lukaknezic avatar lukaknezic commented on June 14, 2024

Yeah I saw you closed the PR, thats okay, Ill include the fix in next PR 😄

from floggy.

mark-nicepants avatar mark-nicepants commented on June 14, 2024

from floggy.

lukaknezic avatar lukaknezic commented on June 14, 2024

Fixed with #26

from floggy.

mark-nicepants avatar mark-nicepants commented on June 14, 2024

Awesome, any ETA on an update on pub.dev? Thanks for fixing

from floggy.

lukaknezic avatar lukaknezic commented on June 14, 2024

@mark-apn Published and available in: 2.0.0+1

from floggy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.