The fate of git hooks lies with you, champion. about ignite-andross HOT 8 CLOSED

I think so ya. I know of 4 projects in the last year we’ve done where someone has said, “what’s going on here”?

Can we replace it with a prompt that says: do you promise to install CI (Y/n)?

from ignite-andross.

Next time @skellock and I disagree I'll just snooze an issue for 9 months and ask again. ;-)

from ignite-andross.

In my personal experience, I really dislike when people put the linter on commit or push.

When you want to get things done, specially when you are newbie to how the company works and the standards) is really annoying to have the linter rejecting you from commit or push.

Now,

This happens to me because I would normally create my own branches, by so, I will make sure before it gets into the master or whatever other branch that you push when you finish the work, I like to squash and clean up my work, so that is why I do care about no having down time for committing or pushing.

But,

At that moment, I wouldn't mind if the CI let me know that I forgot to run the linters and test, that is the value added to the CI anyway.

FWIW, your IDEs will help you with the on time fixes with the plugins which will let you know sometimes what is wrong.

from ignite-andross.

FWIW I like to run linting in VS Code and tests manually + in CI. (Hint: FWIW -- it's worth very little here)

from ignite-andross.

Since there were no objections I'm going to make git hooks optional and update the behavior to lint on commit and test on push.

from ignite-andross.

I'm not super worried about this, so don't take my opinion too seriously.

from ignite-andross.

Ya, coming back to this ticket nearly 9 months later... I'm with @yordis and @ckeeney on this.

Lint-on-stage is a problem for staging parts of a file.

And test-on-commit is a problem for commiting the small changes while still wip'ing other things.

🤷‍♂️ 🤷‍♀️ 🤷‍♂️ 🤷‍♀️ 🤷‍♂️ 🤷‍♀️ 🤷‍♂️ 🤷‍♀️ 🤷‍♂️ 🤷‍♀️ 🤷‍♂️ 🤷‍♀️

from ignite-andross.

@skellock So you're on team no hooks now too? If so I'll just axe them.

from ignite-andross.