I have many warnings about setState on unmount component about react-viewer HOT 11 CLOSED

Fixed in # v2.2.3.

from react-viewer.

try v2.2.4 😆

from react-viewer.

This problem replay if i open viewer, edit image(rotate, scale-mouse well, flip) and when i edit i have many warnings

from react-viewer.

Very big problem - when i close viewer, send warning dont stop. Plz add on componentUnmount unsubscribe eventListener mouse and another events

from react-viewer.

Can you provide a reproduce demo, let me check better.

from react-viewer.

https://monosnap.com/file/nnpjJHPbWKzazrESpXpmQemStU55TW
What i do:

1. Open viewer with image
2. Some action
3. Close viewer
4. Any mouse scroll create many warning this setState on unmount component
5. Open viewer again
6. Some action create many warning this setState on unmount component
7. Close viewer
8. Very more warnings.
9. If many repeat "open - some actions - close" create very big flow warnings multiplication on count repeat

from react-viewer.

Can you provide a small code demo, I can`t reappear this bug.

from react-viewer.

it's all,
I inject Viewer if need, and remove it if not need now

showViewer = () => {
    let images =
      this.props[`${this.props.type}Items`]
        .map((item) => ({
          src: this.downloadLink(item.id),
          alt: item.name
        }))

    return (
      <Viewer
        visible
        onClose={() => { this.setState({ mode: GALLERY }) }}
        images={images}
        activeIndex={this.state.attachmentIndex}
      />)
  }

from react-viewer.

Hi, @infeng please remove listener onResize after unmount

from react-viewer.

@Toxblh you are right.

from react-viewer.

All good, nice work) xD
Thank you

from react-viewer.