Giter Club home page Giter Club logo

Comments (6)

listerr avatar listerr commented on July 17, 2024 2

I know this might be considered a "frontend niceness" but it makes assigning IP addressees a complete pain and unhelpful, and the process makes no sense. It is not as straightforward as "go to the bottom of the list, find the next free one and assign it."

It is "pick through the list of addresses until you get to a high numbered one that looks like it may or may not be in the right sequence" (and a host of other IP address management issues...)

Also VERY ANNOYING is that this list always defaults to IPv6 when I never, ever care about IPv6 in this page, or assign IPv6 addresses in this way, since we already know what those are going to be, they're never picked from a list. I know you want to evangelise IPv6 and all that, but IXPs are already sold on IPv6. It just adds a needless annoying extra click in an already awkward workflow in the admin interface.

With the migration to Laravel, is there some possibility that this can be fixed?

from ixp-manager.

rowanthorpe avatar rowanthorpe commented on July 17, 2024

For reference, to help whoever works on this bug, it seems that this is governed by DataTables which is included from here.

The line that sets the actual sorting seems to be here.

On reflection this will probably be quite complex to change because rather than using DataTable's internal sorting types (string, numeric, date, html) it will require actually parsing the IP addresses, including IPv6 in its compacted form, etc...

from ixp-manager.

barryo avatar barryo commented on July 17, 2024

DataTables allows for custom sort functions (we already actually have
them in places).

It probably means a hidden column linked to the IP addresses with the
int32 for ipv4 and the fully decompressed v6 address.

It's a not insignificant bit of work which only yields some frontend
niceness so it'll be a pretty low priority.

On 19/07/13 14:03, Rowan Thorpe wrote:

For reference, to help whoever works on this bug, it seems that this is
governed by DataTables http://www.datatables.net which is included
from here
https://github.com/inex/IXP-Manager/blob/master/public/js/220-jquery.dataTables-1.9.4.js.

The line that sets the actual sorting seems to be here
https://github.com/inex/IXP-Manager/blob/master/application/controllers/Ipv4AddressController.php#L110.

On reflection this will probably be quite complex to change because
rather than using DataTable's internal sorting types (string, numeric,
date, html) it will require actually parsing the IP addresses, including
IPv6 in its compacted form, etc...


Reply to this email directly or view it on GitHub
#21 (comment).

from ixp-manager.

nickhilliard avatar nickhilliard commented on July 17, 2024

http://datatables.net/plug-ins/sorting, search for "IP addresses".

from ixp-manager.

rowanthorpe avatar rowanthorpe commented on July 17, 2024

Nice 👍 I can see that only accurately sorts IPv4 dot-notation though, but that would still be an improvement for IPv6 (over alphabetical) anyway, until someone wants to contribute a thorough IPv6-sort to Datatables...

from ixp-manager.

listerr avatar listerr commented on July 17, 2024

Also /customer/list needs fixing because it Lexical sorts ASNs instead of numerically.

from ixp-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.