inedo / bmx-gitlegacy Goto Github PK

Having git submodules loaded as part of the Get-Labeled-Source operation would be very useful. Given submodules are not a feature across the board for source providers perhaps it should by default load them, or alternatively control the preference from the provider configuration on a per repository basis.

I'm happy to do a PR but wanted to discuss the potential feature.

Currently the workaround is to just load the submodule as a separate repository and then copy the files in manually or just use git directly.

Port of: Inedo/inedox-git#35

Suggestion from a past life where I hacked this once already but couldn't send a PR. I figured I'd record the idea for y'all in case you want to implement yourselves.

In the case of the "Create Label" action, you can improve the GitHub experience by using the GitHub Release API instead of directly adding a git tag. The Release API will add the git tag for you and also allow you to provide additional information such as kindly setting the Pre-Release status (gives a nice orange "Pre-Release" sticker on the GitHub releases page) and adding informative description data (such as a link back to the BuildMaster build that created the label). This also has the useful benefit that Releases can be queried/created before grabbing a copy of the repository. (In the version I worked on, it would also check for an existing tag of the wanted name and skip trying to add it again, which is closer to how it seems some of the other BuildMaster Source Control plugins work, but the raw git one currently fails if the tag already exists.)

Additionally, it should be possible (although I did not manage to do it) to build triggers to use the Release API for other moments in the life cycle of a build: when a build is cancelled you could delete the release in GitHub which cleans up the releases page; when a build is deployed to production you could remove the "Pre-Release" flag making it eligible for GitHub's useful "Latest Release" sticker.

Suggestion from a past life where I hacked this once already but couldn't send a PR. I figured I'd record the idea for y'all in case you want to implement yourselves.

If you make the GitHub API Path a setting on the repository it allows people to choose between public GitHub and GitHub for Enterprises installations.

Include a built-in client

For a different path, outside of the BuildMaster-defined folders.