Giter Club home page Giter Club logo

Comments (15)

kgn avatar kgn commented on July 18, 2024

It should be possible, it might make sense to add an option to enable it. If you implement it please submit a patch request.

from inappstorewindow.

mkdynamic avatar mkdynamic commented on July 18, 2024

I'll look into this, since I need it for an app I'm building. I scoped it a while back, but wasn't sure where the mask for full screen windows gets set.

from inappstorewindow.

kgn avatar kgn commented on July 18, 2024

After thinking about this more I don't think this is applicable to INAppStoreWindow because the titlebar is hidden in fullscreen mode. Your best bet would probably be to put black rounded corners above your content in the apps main view.

from inappstorewindow.

mkdynamic avatar mkdynamic commented on July 18, 2024

That seems like it might make the transition look odd.

Also, the titlebar can be visible in fullscreen mode (via the option).

from inappstorewindow.

kgn avatar kgn commented on July 18, 2024

What is the option?

from inappstorewindow.

mkdynamic avatar mkdynamic commented on July 18, 2024

https://github.com/indragiek/INAppStoreWindow/blob/master/INAppStoreWindow.m#L235

from inappstorewindow.

kgn avatar kgn commented on July 18, 2024

Oh right, sorry I haven't used that one in an app yet so it slipped my mind. I'll take a look.

from inappstorewindow.

indragiek avatar indragiek commented on July 18, 2024

I think this would be great for consistency with other fullscreen OS X apps. I don't even think showing/not showing rounded corners should be an option, rounded should be the default. Check out Xcode's full screen mode, it has very subtly rounded top corners (2-3px corner radius).

from inappstorewindow.

kgn avatar kgn commented on July 18, 2024

The corners in fullscreen were rounded, however the color behind them was white so they blended in and looked square. I added code to draw a black rect behind the titlebar in fullscreen mode however there is an issue with this where the black rect displays until the window has fully exited fullscreen. I'll investigate and think about a better solution to this issue.

from inappstorewindow.

jakepetroules avatar jakepetroules commented on July 18, 2024

Shouldn't this issue be closed? It looks to me that the issue has already been resolved.

from inappstorewindow.

indragiek avatar indragiek commented on July 18, 2024

As of the latest commit, the corners are still square in fullscreen mode, so I think this should stay open.

from inappstorewindow.

jakepetroules avatar jakepetroules commented on July 18, 2024

Are you sure? Last I checked they are rounded.

from inappstorewindow.

indragiek avatar indragiek commented on July 18, 2024

You're right, the sample app has rounded corners in full screen. I thought they were square because I was checking it in a different app that uses INAppStoreWindow with custom titlebar drawing. Closing.

from inappstorewindow.

jakepetroules avatar jakepetroules commented on July 18, 2024

IIRC 4de7875 (one of the commits you just merged) fixed this for custom drawn title bars.

from inappstorewindow.

indragiek avatar indragiek commented on July 18, 2024

Ah ok, thanks for that!

from inappstorewindow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.