Giter Club home page Giter Club logo

Comments (7)

tytarman avatar tytarman commented on July 30, 2024

oh yay!
I'll dig in and see what I can do.
Thanks for the details in the post.

from index-ui.

rootulp avatar rootulp commented on July 30, 2024

Supply data is coming from the token contract, so it will require a provider.

Why do we want to fallback to the Coingecko currentSupply if we've already fetched the supply from the token contract and have that available in this component (via currentSupply)? Is the supply data that comes from the token contract not reliable?

from index-ui.

0xModene avatar 0xModene commented on July 30, 2024

Supply data is coming from the token contract, so it will require a provider.

Why do we want to fallback to the Coingecko currentSupply if we've already fetched the supply from the token contract and have that available in this component (via currentSupply)? Is the supply data that comes from the token contract not reliable?

The primary is the CG MCAP, not 'currentSupply'. The pricing on CG is generally reliable but the math required to calculate MCAP may not be as accurate as the actual MCAP, which is why it should be the fallback (currentSupply * CG Price).

This should eventually get overwritten with on-chain data that we don't currently have.

from index-ui.

rootulp avatar rootulp commented on July 30, 2024

Right. I understand the best option is CoinGecko market cap. In the fallback scenario, are you proposing we use CoinGecko currentSupply or token contract currentSupply? #336 uses token contract currentSupply.

from index-ui.

0xModene avatar 0xModene commented on July 30, 2024

Right. I understand the best option is CoinGecko market cap. In the fallback scenario, are you proposing we use CoinGecko currentSupply or token contract currentSupply? #336 uses token contract currentSupply.

Token contract current supply, CoinGecko price

from index-ui.

rootulp avatar rootulp commented on July 30, 2024

Token contract current supply, CoinGecko price

Thanks for clarifying and sorry for my confusion. I agree with that proposal. Sorry I split the fix for this into two separate PRs. Can we re-open until #336 or something similar is merged?

from index-ui.

0xModene avatar 0xModene commented on July 30, 2024

Sure thing

from index-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.