Comments (7)
oh yay!
I'll dig in and see what I can do.
Thanks for the details in the post.
from index-ui.
Supply data is coming from the token contract, so it will require a provider.
Why do we want to fallback to the Coingecko currentSupply if we've already fetched the supply from the token contract and have that available in this component (via currentSupply
)? Is the supply data that comes from the token contract not reliable?
from index-ui.
Supply data is coming from the token contract, so it will require a provider.
Why do we want to fallback to the Coingecko currentSupply if we've already fetched the supply from the token contract and have that available in this component (via
currentSupply
)? Is the supply data that comes from the token contract not reliable?
The primary is the CG MCAP, not 'currentSupply'. The pricing on CG is generally reliable but the math required to calculate MCAP may not be as accurate as the actual MCAP, which is why it should be the fallback (currentSupply * CG Price).
This should eventually get overwritten with on-chain data that we don't currently have.
from index-ui.
Right. I understand the best option is CoinGecko market cap. In the fallback scenario, are you proposing we use CoinGecko currentSupply or token contract currentSupply? #336 uses token contract currentSupply.
from index-ui.
Right. I understand the best option is CoinGecko market cap. In the fallback scenario, are you proposing we use CoinGecko currentSupply or token contract currentSupply? #336 uses token contract currentSupply.
Token contract current supply, CoinGecko price
from index-ui.
Token contract current supply, CoinGecko price
Thanks for clarifying and sorry for my confusion. I agree with that proposal. Sorry I split the fix for this into two separate PRs. Can we re-open until #336 or something similar is merged?
from index-ui.
Sure thing
from index-ui.
Related Issues (20)
- Update the partners on the homepage HOT 3
- Remove April MVI farm popup HOT 2
- BED product page shows market cap of $0 HOT 3
- Add connect to rainbow button HOT 1
- Update MVI LM dates HOT 3
- WalletConnect No Longer Working HOT 2
- CORS issue on request to snapshot HOT 1
- Remove SnapshotProposals directory
- DPI logo sporadically doesn't load HOT 2
- Automatic code style formatting HOT 3
- React warnings on How to Buy page HOT 2
- Refactor: useDapp.useTokenBalance HOT 3
- http://localhost:3000/news broken HOT 2
- Rewards monthly dropdown list is clipped inside containing Card. HOT 2
- Read token contract decimals from on-chain HOT 1
- Refactor: consider using numbers in PricesContext
- Investigate Set component allocations with Ledger HOT 3
- Link to the V2 Website
- Fix the background scrolling effect HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from index-ui.