Comments (6)
I would be much happier if we could add hex.pm integration to erlang.mk … but for know, we can do it the rebar3 way
from elvis_core.
This is more a requirement of hex then of rebar3, hex packages can't specify dependencies that are not packages themselves. What tool uploads them, rebar, mix, erlang.mk or some curl doesn't matter.
from elvis_core.
Right, it doesn't matter what tool is used to publish to hex, all that matters is that all dependencies are in hex. Publishing with rebar3 or mix (or any other tool that gets support) is fine.
from elvis_core.
Is it really necessary to have all dependencies in hex? Doesn't it depend on what tool is used to build the project. For example, if I'm building my project with make
(using erlang.mk
) and elvis_core
is a dep that we get from hex.pm, erlang.mk
will download its package and try to build it, since it has a Makefile
with its own deps everything should work. I imagine the same scenario is valid when using rebar
, rebar3
or mix
as long as the package contains a rebar.config
file. Am I wrong?
from elvis_core.
Rebar3 resolves all deps of a hex package based on the registry, it will not fetch additional deps that are defined in rebar.config.
from elvis_core.
@tsloughter Oh, I see. I didn't know that. Thanks!
from elvis_core.
Related Issues (20)
- Unused Variable Names HOT 5
- no_match_in_condition reports a warning even when the condition includes a valid match
- Bug (?) in atom_naming_convention HOT 2
- Using ets:fun2ms without including ms_transform.hrl should be an error HOT 3
- New ruleset `gitignore`
- Propose `gen_server` et all "no-timeout" functions as `no_common_caveats`?
- Have a simple way to run `all` checks (even optional ones) HOT 8
- New rule: consistent file names HOT 2
- New Rule: No Import Type
- New Rule: Unsafe usage of application HOT 1
- Wildcards in no_call_functions MFA HOT 4
- Potential new rule: only call internal_export'ed functions from test code HOT 2
- No consecutive strings
- Rule: Do not use lists on start_link/3,4 and init/1 HOT 3
- no_successive_maps obsolete due to Erlang change?
- New rule: consistent deps applications HOT 3
- max_function_length counts multiple function clauses as a single function HOT 2
- Count `_to_atom` as common caveats? HOT 2
- Should `no_macros` consider `LOG_...` as allowed? HOT 3
- no_successive_maps doesn't work when nested
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elvis_core.