Giter Club home page Giter Club logo

Comments (6)

paulo-ferraz-oliveira avatar paulo-ferraz-oliveira commented on May 29, 2024

Should this be kept open? Is it something we want to take care of? We'd remove the need to sync. changes in the defaults, for example, from elvis to rebar3_lint.

from elvis_core.

elbrujohalcon avatar elbrujohalcon commented on May 29, 2024

I think that elvis_core should be the place to keep the defaults, but I'm not sure this is a pressing issue right now. However, I don't have enough data to know how many people uses elvis as a standalone script vs. how many people uses elvis_core through rebar_lint.

from elvis_core.

paulo-ferraz-oliveira avatar paulo-ferraz-oliveira commented on May 29, 2024

I used to use elvis as a standalone script until I found out about the plugin. In any case, if there's defaults in elvis_core (for an empty/non-existing elvis.config) this means that rebar3_lint has only to import a new version, at every release (well, until @Licenser decides to implement specific options, that is 😄).

from elvis_core.

Licenser avatar Licenser commented on May 29, 2024

I'm not actively changing rebar3_lint but I'm more then happy to merge any PR that improves it's behavior :)

from elvis_core.

elbrujohalcon avatar elbrujohalcon commented on May 29, 2024

Is this solved already, @paulo-ferraz-oliveira ?

from elvis_core.

paulo-ferraz-oliveira avatar paulo-ferraz-oliveira commented on May 29, 2024

Two things:

  1. I'm not actively using the CLI elvis anymore, but assume the issue hasn't been fixed (I saw nothing in my notifications that pointed to it),
  2. I still would like rebar3_lint to not assume any defaults (and leave that to elvis_core), but that's an issue for a different repo (I went to check it, and you've solved it already, hurrah!).

I think it's safe to close.

from elvis_core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.