Comments (6)
Should this be kept open? Is it something we want to take care of? We'd remove the need to sync. changes in the defaults, for example, from elvis
to rebar3_lint
.
from elvis_core.
I think that elvis_core
should be the place to keep the defaults, but I'm not sure this is a pressing issue right now. However, I don't have enough data to know how many people uses elvis
as a standalone script vs. how many people uses elvis_core
through rebar_lint
.
from elvis_core.
I used to use elvis
as a standalone script until I found out about the plugin. In any case, if there's defaults in elvis_core
(for an empty/non-existing elvis.config
) this means that rebar3_lint
has only to import a new version, at every release (well, until @Licenser decides to implement specific options, that is 😄).
from elvis_core.
I'm not actively changing rebar3_lint but I'm more then happy to merge any PR that improves it's behavior :)
from elvis_core.
Is this solved already, @paulo-ferraz-oliveira ?
from elvis_core.
Two things:
- I'm not actively using the CLI
elvis
anymore, but assume the issue hasn't been fixed (I saw nothing in my notifications that pointed to it), I still would like(I went to check it, and you've solved it already, hurrah!).rebar3_lint
to not assume any defaults (and leave that toelvis_core
), but that's an issue for a different repo
I think it's safe to close.
from elvis_core.
Related Issues (20)
- New rule: No Single Clause Maybe Statements
- New rule: Consistent Line Endings
- New rule: Consistent Trailing Blank Line HOT 3
- New rule: Redundant Blank Lines HOT 2
- New rule: Prefer Unquoted Atoms
- `rebar3 lint` unexpectedly warns `_Var ?= val` as `used_ignored_variable` HOT 1
- Drop support for OTP versions below 23. HOT 2
- Broken README links HOT 3
- There are instances where not exporting a type is valid, even if it's used in a spec.
- Add option to ignore non-exported functions on max_function_arity HOT 1
- Unused Variable Names HOT 5
- no_match_in_condition reports a warning even when the condition includes a valid match
- Bug (?) in atom_naming_convention HOT 2
- Using ets:fun2ms without including ms_transform.hrl should be an error HOT 3
- New ruleset `gitignore`
- Propose `gen_server` et all "no-timeout" functions as `no_common_caveats`?
- Have a simple way to run `all` checks (even optional ones) HOT 8
- New rule: consistent file names HOT 2
- New Rule: No Import Type
- New Rule: Unsafe usage of application HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elvis_core.