Image decay on the new A12 Bionic chip about waifu2x-ios HOT 10 CLOSED

Turned out that setting computeUnits in MLModelConfiguration to cpuAndGPU can bypass neural engine for now.

The MPSNN implementation is partially finished. It will be released if it can be faster or results in better quality than Core ML in benchmarks.

In the future if I could get hands on a device with A12 chip, I still wish to try fixing for neural engine since it should be much faster even than GPU mode.

from waifu2x-ios.

I can confirm the image quality issue on my XS 256GB. Artifacts are visible on color gradients, the final images are unusable.
Running in CPU only mode quality is good as expected, however the XS takes about twice as much time to complete a task when compared to a 7 Plus.
I am available for trying out new builds.

from waifu2x-ios.

With regard to the waifu2x app in the App Store (which is what I am testing), is/will this app rely on both cpu And GPU to run the Core ML model, then?

from waifu2x-ios.

With regard to the waifu2x app in the App Store (which is what I am testing), is/will this app rely on both cpu And GPU to run the Core ML model, then?

Currently it only has Core ML as back end, which relys on GPU. If GPU is not supported it will fallback to CPU.

from waifu2x-ios.

What bugs me (what I don’t understand since I am not an expert on this matter) is why the performance on iPhone 7 Plus (A10 SOC, no neural engine) is still ~2X faster than on XS, excluding neural engine factors.
Running both iPhone models in Cpu Only mode, I see the A12 benefits (~35% faster cpu than the A10 cpu).
Disabling the Cpu Only however, the latest XS app still generates artifacts, implying it is still trying to use the neural engine, instead of relying on the GPU (as the A10 does).

from waifu2x-ios.

Weird... The model.configuration.computeUnits should have been set to .cpuAndGPU. It seems that this fix is ineffective. I will try to get hands on a device with A12 chip. Also a MPSNN update will be considered before then.

from waifu2x-ios.

Can confirm, also an issue on A13

from waifu2x-ios.

Can confirm, also an issue on A13

Can you provide a demo image and configurations? I cannot reproduce this issue on iPhone 11 Pro even with neural engine enabled.

from waifu2x-ios.

Sorry, I meant with coreML implementation.
There is still some banding; not as much as a12, but not as smooth as MPSCNN.

Overall it’s fine but I’ll see if I can get an example once I get home from school

from waifu2x-ios.

from waifu2x-ios.