Could not find parent dir! about synp HOT 16 CLOSED

Hi there,
@imsnif @LuudJanssen

I'll look for what could break. Sorry for the inconvenience.

from synp.

@alexiusp, @LuudJanssen,

Everything should be fixed in v1.8.2. If not, feel free to open another one issue.

from synp.

Sorry for losing the track. In version 1.8.2 everything works as expected. Thank you!

from synp.

Oi, sorry about that! @antongolub, feel like taking a look? If you don't have time, let me know and I'll delve into your changes and see what's up. @LuudJanssen, for now working with 1.7 works for you?

from synp.

No problem @imsnif! Yes, running npx [email protected] --source-file yarn.lock works for me.

from synp.

@imsnif,

Could you verify #47 fix and release a patch?

from synp.

I have the same issue. Fixing the version of synp to 1.7.0 helps.

from synp.

@LuudJanssen, @alexiusp - could you try with 1.8.1? Is it working for you?

from synp.

@LuudJanssen, @alexiusp ,
Any news?

The latest beta build is available as @antongolub/synp package. If everything works fine, we would like to release the pull request and close the issue.

from synp.

I have tried version 1.8.1. Issue mentioned above has gone, but I have another issue. Seems like this version of synp works incorrectly with private repositories and/or with dependencies referenced by direct github link instead of npm package name. When I run synp v.1.8.1 with one of my repos I see this:

synp --source-file yarn.lock --force
Invalid URL: git+ssh://[email protected]:xxxx/xxxx_components.git#0b2e****637d
Usage: synp [options]

Options:
-V, --version output the version number
-s, --source-file [source-file] The path to the yarn.lock or
package-lock.json to be converted
-f, --force Force overwrite destination file
--with-workspace Enable experimental npm lockfile v2
processing
-h, --help display help for command

In my package.json I have a dependency like this:

"xxxx_components": "git+ssh://[email protected]:xxxx/xxxx_components.git"

It's a private repository. Build process on Jenkins is set up correctly and all necessary files are in node_modules. Yarn also understands this kind of dependencies and install them properly.

from synp.

@alexiusp
I see... I've replaced deprecated url.parse(val) call with new url.URL(val).

standard: Use JavaScript Standard Style (https://standardjs.com)
  /Users/a.golub/projects/synp/lib/lockfileV1/entry.js:8:26: 'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead.

from synp.

@alexiusp

Reverted. Could you try the latest beta? npx @antongolub/[email protected]

from synp.

Hey @antongolub - let's go forward with your fixes. I think if it doesn't fix stuff for @alexiusp we can re-examine it. Is everything merged, can I bump the version and publish?

from synp.

from synp.

@antongolub - the last commit on master is 1.8.1

from synp.

@imsnif
AFK. Could you merge the latest PR?

Ready for release.

from synp.