Giter Club home page Giter Club logo

Comments (9)

DarthSim avatar DarthSim commented on May 16, 2024 3

🎉 imgproxy v2.0 has been released 🎉 Take a look at the new features, including new URL format, presets and default config (via presets): https://github.com/DarthSim/imgproxy/blob/master/CHANGELOG.md#v200

from imgproxy.

princemaple avatar princemaple commented on May 16, 2024 2

It is not 12factor-ready;

I take back the config file part. I would load configs from a config server, but that is too specific, instead I just mentioned config file. I still think presets could be useful; how to load them is app / org dependent.

It is not simple;

It's just switching from parsing the url to populating the processingOptions with a preset. (still need to get the preset though, but I don't see what's hard about that)

It doesn't solve any problem.

It does not solve any significant technical problem. Organization wise, you could let the design team handle the config presets and the dev team only need to know when to use which preset, e.g. thumbnail in list views vs large image in detail views. Given there is nice config/infra setup. Also, it would kill a few bytes if you have lots of images and you have to return complete urls from your app server to your clients.

from imgproxy.

princemaple avatar princemaple commented on May 16, 2024 1

Thanks a lot for the great works!

from imgproxy.

DarthSim avatar DarthSim commented on May 16, 2024

I'm going to keep the current URL format as a common way to use imgproxy, and develop a new format for a more advanced processing. But this feature is not going to appear in a short time because of my work load.

from imgproxy.

princemaple avatar princemaple commented on May 16, 2024

Might be great to be able to define presets with a config file, then simply do /%signature/%preset/%encoded_url.%extension

from imgproxy.

DarthSim avatar DarthSim commented on May 16, 2024

It is totally no:

  1. It is not 12factor-ready;
  2. It is not simple;
  3. It doesn't solve any problem.

from imgproxy.

DarthSim avatar DarthSim commented on May 16, 2024

I take back the config file part. I would load configs from a config server, but that is too specific, instead I just mentioned config file. I still think presets could be useful; how to load them is app / org dependent.

Still doesn't work well with 12factor, and still too specific for your case

It's just switching from parsing the url to populating the processingOptions with a preset. (still need to get the preset though, but I don't see what's hard about that)

It's not simple for usage. Instead of just specifying params, you need to make a config file.

It does not solve any significant technical problem. Organization wise, you could let the design team handle the config presets and the dev team only need to know when to use which preset, e.g. thumbnail in list views vs large image in detail views. Given there is nice config/infra setup. Also, it would kill a few bytes if you have lots of images and you have to return complete urls from your app server to your clients.

The design team shouldn't config your servers or apps, it's developers purpose. In the end, frontend guys will put the URLs in the template. If you write the code to generate URLs, you can add presets support there without modifying imgproxy, just like we did.

Actually, presets aren't much related to this issue, it's better to open another one if you'd like to discuss the feature.

from imgproxy.

princemaple avatar princemaple commented on May 16, 2024

Actually, presets aren't much related to this issue, it's better to open another one if you'd like to discuss the feature.

Cool.

from imgproxy.

xtagon avatar xtagon commented on May 16, 2024

In my use case, changing the URL format would help with caching. If parts like the signature (we sign S3 URLs as well as imgproxy requests) could be kept in query strings, and the rest in the URL path, then we can ignore query strings on the CDN side to keep the signature from busting the cache. Has anyone else run into this? How do you solve it?

from imgproxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.