Require support for BMP files about imageflow HOT 11 OPEN

On Tue, Feb 21, 2023, 2:11 PM villagemedia ***@***.***> wrote: We are attempting to move from ImageResizer to ImageFlow. We noticed a lot of errors after switching, and it seems that ImageFlow does not support bitmaps. We have user submitted content that has a .jpg extension, but it's actually a bitmap. These resize just fine in ImageResizer, but fail in ImageFlow. ImageflowException: ImageMalformed: NoEnabledDecoderFound: No ENABLED decoder found for file starting in [42, 4D, 36, C4, 6D, 1, 0, 0, 0, 0, 36, 0] at imageflow_core\src\codecs\mod.rs:155:20 https://github.com/imazen/imageflow/blob/22a2bf99f278d4dd7b8da65ee1604b5f84eb1d50/imageflow_core/src/codecs/mod.rs#L155 imageflow_core\src\context.rs:194:103 https://github.com/imazen/imageflow/blob/22a2bf99f278d4dd7b8da65ee1604b5f84eb1d50/imageflow_core/src/context.rs#L194 imageflow_core\src\context.rs:235:66 https://github.com/imazen/imageflow/blob/22a2bf99f278d4dd7b8da65ee1604b5f84eb1d50/imageflow_core/src/context.rs#L235 imageflow_abi\src\lib.rs:703:62 https://github.com/imazen/imageflow/blob/22a2bf99f278d4dd7b8da65ee1604b5f84eb1d50/imageflow_abi/src/lib.rs#L703 — Reply to this email directly, view it on GitHub <#626>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA2LH5KG5VBYZOM3VDH26TWYUVR3ANCNFSM6AAAAAAVDQZKYI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

It's exceptionally rare for DIBs to be used (you're the first), but I suppose it's not a complicated codec to implement. Do you have a support plan with us? On Tue, Feb 21, 2023, 2:11 PM villagemedia ***@***.***> wrote: > We are attempting to move from ImageResizer to ImageFlow. We noticed a lot > of errors after switching, and it seems that ImageFlow does not support > bitmaps. We have user submitted content that has a .jpg extension, but it's > actually a bitmap. These resize just fine in ImageResizer, but fail in > ImageFlow. > > ImageflowException: ImageMalformed: NoEnabledDecoderFound: No ENABLED > decoder found for file starting in [42, 4D, 36, C4, 6D, 1, 0, 0, 0, 0, 36, > 0] at > imageflow_core\src\codecs\mod.rs:155:20 > > https://github.com/imazen/imageflow/blob/22a2bf99f278d4dd7b8da65ee1604b5f84eb1d50/imageflow_core/src/codecs/mod.rs#L155 > imageflow_core\src\context.rs:194:103 > > https://github.com/imazen/imageflow/blob/22a2bf99f278d4dd7b8da65ee1604b5f84eb1d50/imageflow_core/src/context.rs#L194 > imageflow_core\src\context.rs:235:66 > > https://github.com/imazen/imageflow/blob/22a2bf99f278d4dd7b8da65ee1604b5f84eb1d50/imageflow_core/src/context.rs#L235 > imageflow_abi\src\lib.rs:703:62 > > https://github.com/imazen/imageflow/blob/22a2bf99f278d4dd7b8da65ee1604b5f84eb1d50/imageflow_abi/src/lib.rs#L703 > > — > Reply to this email directly, view it on GitHub > <#626>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAA2LH5KG5VBYZOM3VDH26TWYUVR3ANCNFSM6AAAAAAVDQZKYI > > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > — Reply to this email directly, view it on GitHub <#626>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT5Y6H3ZXQE6QI5RYVZAM6DWYU4LNANCNFSM6AAAAAAVDQZKYI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

On Fri, Feb 24, 2023 at 12:21 AM Lilith River ***@***.***> wrote: I've moved this to the Imageflow project for consideration. I typically don't implement features unless there are multiple users needing them, but I'll keep it in mind. For now, I would suggest normalizing your bitmaps to .png. — Reply to this email directly, view it on GitHub <#626 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT5Y6H5GIS47QBBFKJBNVATWZBANDANCNFSM6AAAAAAVGPJYP4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

On Fri, Feb 24, 2023, 6:09 AM villagemedia ***@***.***> wrote: I would love to normalize to png or jpg, but the problem is that we have public (uncontrolled) users submitting images. Until this experience, I wasn't aware that some users were submitting bmp masquerading as jpg. Regardless, thank you for your consideration! On Fri, Feb 24, 2023 at 12:21 AM Lilith River ***@***.***> wrote: > I've moved this to the Imageflow project for consideration. I typically > don't implement features unless there are multiple users needing them, but > I'll keep it in mind. For now, I would suggest normalizing your bitmaps to > .png. > > — > Reply to this email directly, view it on GitHub > <#626 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AT5Y6H5GIS47QBBFKJBNVATWZBANDANCNFSM6AAAAAAVGPJYP4 > > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#626 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA2LH4C554UHJKENDJ3XGLWZCXJRANCNFSM6AAAAAAVGPJYP4> . You are receiving this because you commented.Message ID: ***@***.***>

I remember at one point Paint defaulted to .bmp, but is that still occurring with new incoming files? Some upload tools can check the first few bytes - the file signature - and can reject invalid formats. We have a C# method for this on the server side as well. On Fri, Feb 24, 2023, 6:09 AM villagemedia ***@***.***> wrote: > I would love to normalize to png or jpg, but the problem is that we have > public (uncontrolled) users submitting images. Until this experience, I > wasn't aware that some users were submitting bmp masquerading as jpg. > > Regardless, thank you for your consideration! > > On Fri, Feb 24, 2023 at 12:21 AM Lilith River ***@***.***> > wrote: > > > I've moved this to the Imageflow project for consideration. I typically > > don't implement features unless there are multiple users needing them, > but > > I'll keep it in mind. For now, I would suggest normalizing your bitmaps > to > > .png. > > > > — > > Reply to this email directly, view it on GitHub > > < #626 (comment) > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AT5Y6H5GIS47QBBFKJBNVATWZBANDANCNFSM6AAAAAAVGPJYP4 > > > > . > > You are receiving this because you authored the thread.Message ID: > > ***@***.***> > > > > — > Reply to this email directly, view it on GitHub > <#626 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAA2LH4C554UHJKENDJ3XGLWZCXJRANCNFSM6AAAAAAVGPJYP4 > > . > You are receiving this because you commented.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#626 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT5Y6H6C4TIWJC2D6FMVWC3WZDHXBANCNFSM6AAAAAAVGPJYP4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

On Fri, Feb 24, 2023, 8:31 AM villagemedia ***@***.***> wrote: Shockingly yes, this happened very recently. I searched for cameras or phones that might do this, but found nothing. We will scan the first bytes and block these moving forward. No idea how many exist on our platform like this, however. On Fri, Feb 24, 2023 at 10:29 AM Lilith River ***@***.***> wrote: > I remember at one point Paint defaulted to .bmp, but is that still > occurring with new incoming files? > > Some upload tools can check the first few bytes - the file signature - and > can reject invalid formats. We have a C# method for this on the server side > as well. > > On Fri, Feb 24, 2023, 6:09 AM villagemedia ***@***.***> wrote: > > > I would love to normalize to png or jpg, but the problem is that we have > > public (uncontrolled) users submitting images. Until this experience, I > > wasn't aware that some users were submitting bmp masquerading as jpg. > > > > Regardless, thank you for your consideration! > > > > On Fri, Feb 24, 2023 at 12:21 AM Lilith River ***@***.***> > > wrote: > > > > > I've moved this to the Imageflow project for consideration. I typically > > > don't implement features unless there are multiple users needing them, > > but > > > I'll keep it in mind. For now, I would suggest normalizing your bitmaps > > to > > > .png. > > > > > > — > > > Reply to this email directly, view it on GitHub > > > < > #626 (comment) > > >, > > > or unsubscribe > > > < > > > https://github.com/notifications/unsubscribe-auth/AT5Y6H5GIS47QBBFKJBNVATWZBANDANCNFSM6AAAAAAVGPJYP4 > > > > > > . > > > You are receiving this because you authored the thread.Message ID: > > > ***@***.***> > > > > > > > — > > Reply to this email directly, view it on GitHub > > < #626 (comment) > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AAA2LH4C554UHJKENDJ3XGLWZCXJRANCNFSM6AAAAAAVGPJYP4 > > > > . > > You are receiving this because you commented.Message ID: > > ***@***.***> > > > > — > Reply to this email directly, view it on GitHub > <#626 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AT5Y6H6C4TIWJC2D6FMVWC3WZDHXBANCNFSM6AAAAAAVGPJYP4 > > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#626 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA2LH3OUPCCZQDCTBR4GXLWZDH6XANCNFSM6AAAAAAVGPJYP4> . You are receiving this because you commented.Message ID: ***@***.***>

On Sat, Feb 25, 2023, 3:44 PM Vladimir Varlamov ***@***.***> wrote: Don't take it as rudeness, but I thought imageflow was positioning itself as a replacement for imagemagick, but it turned out to be an enterprise server with a support plan... Our users also send anything to the server: what is displayed on their systems with a preview. This is a wild world and only on servers is it normalized. So, for good reason, the question on the agenda is not "why", but "when". — Reply to this email directly, view it on GitHub <#626 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA2LHYU344IGHGYWRTTKJTWZKDMZANCNFSM6AAAAAAVGPJYP4> . You are receiving this because you commented.Message ID: ***@***.***>

No, Imageflow doesn't aim to try to parse every image format or implement every feature. The focus is to provide very secure and very performant image processing for key web image formats, with exceptionally good file compression and image quality. If you look through these 630 vulnerabilities in ImageMagick, you'll notice a pattern - they tend to be about obscure image formats: https://www.cvedetails.com/vulnerability-list/vendor_id-1749/Imagemagick.html On Sat, Feb 25, 2023, 3:44 PM Vladimir Varlamov ***@***.***> wrote: > Don't take it as rudeness, but I thought imageflow was positioning itself > as a replacement for imagemagick, but it turned out to be an enterprise > server with a support plan... > Our users also send anything to the server: what is displayed on their > systems with a preview. This is a wild world and only on servers is it > normalized. > So, for good reason, the question on the agenda is not "why", but "when". > > — > Reply to this email directly, view it on GitHub > <#626 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAA2LHYU344IGHGYWRTTKJTWZKDMZANCNFSM6AAAAAAVGPJYP4 > > . > You are receiving this because you commented.Message ID: > ***@***.***> > — Reply to this email directly, view it on GitHub <#626 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AT5Y6HY57NGNCKIU4IKWMALWZLXZZANCNFSM6AAAAAAVGPJYP4> . You are receiving this because you authored the thread.Message ID: ***@***.***>