Test on AppVeyor about meta HOT 16 CLOSED

👍 Example: https://github.com/gruntjs/grunt/blob/master/appveyor.yml

from meta.

First I introduced AppVeyor to imagemin-jpeg-recompress.
It works correctly.

https://github.com/imagemin/imagemin-jpeg-recompress#imagemin-jpeg-recompress--

from meta.

We should switch that Travis badge to be flat so they look nicer together.

from meta.

Like this?

from meta.

Yup

from meta.

shields have a badge for Appveyor too.

from meta.

I'd rather use original AppVeyor badge.
It's difficult to see which badge represents the result of AppVeyor.

from meta.

True.

from meta.

@shinnn, can we remove AppVeyor from the repos? It's slow, mostly fails and doesn't show any good output. We can use it on the main imagemin repo (and maybe the plugins) when/if we can use a newer npm version.

from meta.

@kevva

We can fix a lot more error on Windows with more cross-platform code, like this commit. I still want to continue testing on AppVeyor.

However, as you know, it's very hard to rebuild binaries on AppVeyor. They fails without any outputs and we can't find the causes.
So, How about skipping rebuilding tests on AppVeyor by using is-appveyor?

from meta.

I created a fork which skips the 'rebuild the cwebp binaries' test on AppVeyor.

It passes the test.

from meta.

I'm fine with us continuing using AppVeyor as long as I don't have to care about it.

from meta.

I don't care if it fails and shows good error output. But currently it just shows that it failed but not why. AppVeyor is so bad imo. The commit you're referring to is a conscious decision by me (to use &&). If we are writing stupid workarounds for Windows we're doing it wrong. I rather let the tests fail on Windows.

from meta.

I agree with you that we shouldn't write stupid workarounds.

OK, now I'd like to propose:

• Remove AppVeyor badges from *-bin repos
• Continue testing imagemin and imagemin plugins on AppVeyor
• Create and remove temporary directories with mkdir and rm
• Create and remove directories programmatically after ava supports before and after. (imagemin/jpeg-recompress-bin@481046c#commitcomment-8256698) Do you have any plans for them, @sindresorhus?

What do you think?

from meta.

Create and remove directories programmatically after ava supports before and after. (imagemin/jpeg-recompress-bin@481046c#commitcomment-8256698) Do you have any plans for them, @sindresorhus?

Yes, it's top pri for ava, but probably won't happen for a while, as I'll be traveling.

from meta.

@shinnn, yup, sounds good to me. Build scripts won't work on Windows 90% of the time anyway.

@sindresorhus, I could write a fast temporary patch that implements it if you want to.

from meta.