Giter Club home page Giter Club logo

Comments (8)

isaachinman avatar isaachinman commented on June 19, 2024 6

@imagekitio Just want to mention that I briefly interacted with your product as a potential customer, and have been put off entirely by this issue.

It's one thing that you wouldn't add types for a commercial, paid-for product, but another that you aren't even writing your source in TypeScript in the first place.

Neither of those things inspire any sort of confidence in your product.

from imagekit-javascript.

manu4543 avatar manu4543 commented on June 19, 2024 5

@brunosmm, I apologize for the confusion and delayed response. When I mentioned we wouldn't be able to add TS anytime in the coming months, it includes everything - finding the best way to do it, writing new code, reviewing PR, testing, and merging. I believe https://github.com/DefinitelyTyped/DefinitelyTyped would be the right place for you to make contributions. They actively work on adding new type definitions to existing repositories. So I will be closing this issue, as we won't adding TS definitions as part of this repo.

@kevinclarkadstech Yes, it's a commercial product. We are always working hard to bring all our SDKs up to speed with the latest requirements and the features being requested in the product and appreciate the effort being put in by the dev community in helping us with the same. Unfortunately, this issue is not our priority at the moment. If lack of typescripts is a dealbreaker for you, you should go ahead with one of the other options for now.

from imagekit-javascript.

brunosmm avatar brunosmm commented on June 19, 2024 4

@imagekitio contribution added, it's an adaptation from the types I created for my project, gist here, based on https://github.com/DefinitelyTyped/DefinitelyTyped/blob/08f078e1e0d3da2f2dde1a71fb8d66b71971413d/types/imagekit/ as reference.

Credits to @kemicofa and @romdim;

from imagekit-javascript.

brunosmm avatar brunosmm commented on June 19, 2024 4

Hey @imagekitio,
You asked for contributions but didn't even look at the PR... Do you really want contributions?

from imagekit-javascript.

imagekitio avatar imagekitio commented on June 19, 2024 3

@brunosmm Contributions are welcome :) We won't be working on adding TS in the next couple of months.

from imagekit-javascript.

kevinclarkadstech avatar kevinclarkadstech commented on June 19, 2024 3

@imagekitio @manu4543 you guys must be small potatoes if you cannot even review a PR for months. Another good reason not to inspire confidence @imagekitio @brunosmm . I just went with Cloudinary.

from imagekit-javascript.

brunosmm avatar brunosmm commented on June 19, 2024 2

Adding TS will facilitate a lot.

from imagekit-javascript.

kevinclarkadstech avatar kevinclarkadstech commented on June 19, 2024 2

Hey @imagekitio,

You asked for contributions but didn't even look at the PR... Do you really want contributions?

This would make me livid. Striking this service out as one that I would EVER use. It's a commercial product, not open source.

from imagekit-javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.