Compile error when building version 2.9.0 about strelka HOT 6 CLOSED

Thanks for checking on this. You aren't doing anything wrong, but this looks like a gcc and boost that aren't covered in test. Could you let us know:

1. What is the OS?
2. Where is this boost from: Is this an OS package installation or something you've compiled yourself? If the latter, which version of the compiler was used to build boost?
3. Does compilation fail when using the default OS g++ version?

With these sorts of details we could probably reproduce the issue in docker without too much trouble.

from strelka.

1. OS is Ubuntu 16.04:

$ cat /etc/*-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.3 LTS"
NAME="Ubuntu"
VERSION="16.04.3 LTS (Xenial Xerus)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 16.04.3 LTS"
VERSION_ID="16.04"
HOME_URL="http://www.ubuntu.com/"
SUPPORT_URL="http://help.ubuntu.com/"
BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/"
VERSION_CODENAME=xenial
UBUNTU_CODENAME=xenial

2. Boost installed from source with gcc version 7.2.0:

wget -O boost_1_65_1.tar.gz http://sourceforge.net/projects/boost/files/boost/1.65.1/boost_1_65_1.tar.gz/download
tar xzvf boost_1_65_1.tar.gz && cd boost_1_65_1
./bootstrap.sh --prefix=/usr/local
./b2 cxxflags="-std=c++11"
./b2 install

3. Compilation also fails with default gcc (version 5.4.1).

from strelka.

Thanks! Your build example for boost looks like it is using default gcc. Do you have gcc-7 aliased to gcc?

I think the details above are sufficient for us to try to recreate. The best suggestion I can make before then is to try to force strelka to use its vendored copy of boost by deleting the build dir and changing the configuration to:

BOOST_ROOT= ../configure --jobs=4 --prefix=../bin

from strelka.

Looks like there were minor issues with both boost 1.64+ and gcc7+.

from strelka.

Fixes are now on master. Please reopen if you're still having issues.

from strelka.

Hi, using boost 1.66 and gcc8.3 still facing the same issue mentioned above.
In file included from /opt/rbt_boost/include/boost/serialization/set.hpp:24,
from smc/ripple/gossip.cc:1:
/opt/rbt_boost/include/boost/serialization/access.hpp: In instantiation of 'static void boost::serialization::access::serialize(Archive&, T&, unsigned int) [with Archive = boost::archive::binary_iarchive; T = boost::array<unsigned char, 20>]':
/opt/rbt_boost/include/boost/serialization/serialization.hpp:68:22: required from 'void boost::serialization::serialize(Archive&, T&, unsigned int) [with Archive = boost::archive::binary_iarchive; T = boost::array<unsigned char, 20>]'
/opt/rbt_boost/include/boost/serialization/serialization.hpp:126:14: required from 'void boost::serialization::serialize_adl(Archive&, T&, unsigned int) [with Archive = boost::archive::binary_iarchive; T = boost::array<unsigned char, 20>]'
/opt/rbt_boost/include/boost/archive/detail/iserializer.hpp:189:40: required from 'void boost::archive::detail::iserializer<Archive, T>::load_object_data(boost::archive::detail::basic_iarchive&, void*, unsigned int) const [with Archive = boost::archive::binary_iarchive; T = boost::array<unsigned char, 20>]'
/opt/rbt_boost/include/boost/archive/detail/iserializer.hpp:121:1: required from 'class boost::archive::detail::iserializer<boost::archive::binary_iarchive, boost::array<unsigned char, 20> >'
/opt/rbt_boost/include/boost/archive/detail/iserializer.hpp:411:13: required from 'static void boost::archive::detail::load_non_pointer_type::load_standard::invoke(Archive&, const T&) [with T = boost::array<unsigned char, 20>; Archive = boost::archive::binary_iarchive]'
/opt/rbt_boost/include/boost/archive/detail/iserializer.hpp:463:22: [ skipping 3 instantiation contexts, use -ftemplate-backtrace-limit=0 to disable ]
/opt/rbt_boost/include/boost/archive/basic_binary_iarchive.hpp:75:7: required from 'void boost::archive::basic_binary_iarchive::load_override(T&) [with T = boost::array<unsigned char, 20>; Archive = boost::archive::binary_iarchive]'
/opt/rbt_boost/include/boost/archive/binary_iarchive_impl.hpp:58:9: required from 'void boost::archive::binary_iarchive_impl<Archive, Elem, Tr>::load_override(T&) [with T = boost::array<unsigned char, 20>; Archive = boost::archive::binary_iarchive; Elem = char; Tr = std::char_traits]'
/opt/rbt_boost/include/boost/archive/detail/interface_iarchive.hpp:68:9: required from 'Archive& boost::archive::detail::interface_iarchive::operator>>(T&) [with T = boost::array<unsigned char, 20>; Archive = boost::archive::binary_iarchive]'
./libs/dbi/serialize.h:70:16: required from 'T db::deserialize(const ByteA&) [with T = boost::array<unsigned char, 20>; db::ByteA = std::vector]'
smc/ripple/gossip.cc:123:58: required from 'void rpl::core::Gossip::handle_update(boost::shared_ptrFiji::FijiMsgClusterUpdate) [with Deps = rpl::test::Stubs]'
smc/ripple/gossip.cc:263:16: required from here
/opt/rbt_boost/include/boost/serialization/access.hpp:116:11: error: 'class boost::array<unsigned char, 20>' has no member named 'serialize'

from strelka.