Issue with json when compiling about paragraph HOT 9 CLOSED

Solved by making the change made in this commit to json.hpp

However, I'm leaving this open since the json.hpp file included in Paragraph should probably be updated.

from paragraph.

Thank you for reporting and solving the issue! All developers are off this week but we will incorporate the fix early next week. Also, if you’d like, please feel free to make a pull request.

-Egor

from paragraph.

Hi Guys,
have you had a chance to fix this. I am running into the same problem on our cluster.
Thx
Fritz

from paragraph.

I couldn't reproduce this build issue, even after installing gcc5 (5.5) on my system. But I made a branch with the change suggested by @RSherman15. Could you try branch 'GH4' and let me know if it works for you. If yes, we can make a hotfix release with that.
Longer term, for the next paragraph release, we'll update the library or remove the dependency completely

from paragraph.

Also I have created a repository that show how to compile on CentOS + has a script create a binary using Docker that can then just be unpacked + run on CentOS.

https://github.com/pkrusche/CentOS-Docker-build

Hope this is useful!

from paragraph.

@RSherman15 does the last version fix this for you? I’ve tried it from scratch on Ubuntu 16.04 with gcc 5.4 and it looks fine there.

from paragraph.

Since I was able to get it compiled by modifying the included json.hpp file, I'm not sure if the Docker build works or not as I haven't tried it - sorry!

from paragraph.

I changed to this and it makes compiler happy

const bool is_negative = !(x>=0);

from paragraph.

I think the Docker build should be working now. I've created a PR here: #11 to fix an unrelated Docker build issue that has come up because we were using Ubuntu 17.04 as a base.

from paragraph.