Giter Club home page Giter Club logo

Comments (3)

ilevkivskyi avatar ilevkivskyi commented on September 23, 2024

Yes, I think it is a bug. We support X | Y syntax in is_union_type(). I am not sure what the value get_origin() should return (probably we should match typing behavior), but definitely not None.

from typing_inspect.

bernt-matthias avatar bernt-matthias commented on September 23, 2024

We support X | Y syntax in is_union_type()

Thanks for the tip. I guess this will work for me.

I am not sure what the value get_origin() should return

From the docs: Union type; Union[X, Y] is equivalent to X | Y .. so they should behave the same, or?

probably we should match typing behavior

Also a good idea. But maybe (just maybe) upstream is wrong :)

from typing_inspect.

JelleZijlstra avatar JelleZijlstra commented on September 23, 2024

In Python 3.13 we may well merge types.UnionType and typing.Union: python/cpython#105499. But in earlier Python versions we're not going to change the upstream behavior.

I would recommend typing-inspect to match the behavior of typing.get_origin, so get_origin(int | str) is types.UnionType and get_origin(Union[int, str]) is typing.Union.

from typing_inspect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.