Giter Club home page Giter Club logo

Comments (4)

ikawaha avatar ikawaha commented on June 14, 2024 2

レポートありがとうございます!

こちらのテーブルを参考に https://www.asahi-net.or.jp/~ax2s-kmtn/ref/jisx0208.html
JIS X 0208 の全文字をチェックしてみたところ、ご報告いただいた 以外にもいくつか落としているものがあることが分かりました。修正作業中ですが、ご報告まで。

=== RUN   TestIs_Golden
    discriminator_test.go:106: line=141, want Is(Å)=true, got false
    discriminator_test.go:106: line=142, want Is(‰)=true, got false
    discriminator_test.go:106: line=143, want Is(♯)=true, got false
    discriminator_test.go:106: line=144, want Is(♭)=true, got false
    discriminator_test.go:106: line=145, want Is(♪)=true, got false
    discriminator_test.go:106: line=146, want Is(†)=true, got false
    discriminator_test.go:106: line=147, want Is(‡)=true, got false
    discriminator_test.go:106: line=148, want Is(¶)=true, got false
    discriminator_test.go:106: line=149, want Is(◯)=true, got false
    discriminator_test.go:106: line=3515, want Is(賄)=true, got false
    discriminator_test.go:106: line=3516, want Is(脇)=true, got false // ← ご報告いただいたもの
    discriminator_test.go:106: line=3517, want Is(惑)=true, got false
    discriminator_test.go:106: line=3518, want Is(枠)=true, got false
    discriminator_test.go:106: line=3519, want Is(鷲)=true, got false
    discriminator_test.go:106: line=3520, want Is(亙)=true, got false
    discriminator_test.go:106: line=3521, want Is(亘)=true, got false
    discriminator_test.go:106: line=3522, want Is(鰐)=true, got false
    discriminator_test.go:106: line=3523, want Is(詫)=true, got false
    discriminator_test.go:106: line=3524, want Is(藁)=true, got false
    discriminator_test.go:106: line=3525, want Is(蕨)=true, got false
    discriminator_test.go:106: line=3526, want Is(椀)=true, got false
    discriminator_test.go:106: line=3527, want Is(湾)=true, got false
    discriminator_test.go:106: line=3528, want Is(碗)=true, got false
    discriminator_test.go:106: line=3529, want Is(腕)=true, got false
    discriminator_test.go:106: line=6956, want Is(熙)=true, got false
--- FAIL: TestIs_Golden (0.00s)

from encoding.

shu-bc avatar shu-bc commented on June 14, 2024 1

対応ありがとうございます。いつも使わせていただいて助かっております

from encoding.

ikawaha avatar ikawaha commented on June 14, 2024

抜けてしまった文字は以下:

ʼn♯♭♪†‡¶◯賄脇惑枠鷲亙亘鰐詫藁蕨椀湾碗腕熙

表の以下の部分の模様。

JIS_X_0208コード表_-_CyberLibrarian

JIS_X_0208コード表_-_CyberLibrarian

JIS_X_0208コード表_-_CyberLibrarian

from encoding.

ikawaha avatar ikawaha commented on June 14, 2024

sjis のテーブルから unicode のテーブルを生成して判定範囲を決定しているのですが、そもそもの sjis のテーブルのコード範囲を 2区、47区、84区で typo してました。

修正をいれて v1.2.1 としてリリースしました。ご確認ください。

レポート本当にありがとうございます!助かりました 🙏

from encoding.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.