Giter Club home page Giter Club logo

Comments (5)

Martin-Jung avatar Martin-Jung commented on May 30, 2024

Not quite sure what you mean, but passing on predictions to the next models is the default for engines that don't support joint estimation of multiple datasets, the parameter method_integration applies (default: "predictor"). Extracted predictors are in this case added.

  • It needs to pass on predictions among multiple steps. One can think of an example where like 3 or more different datasets are added.
  • Ultimately the number of predictors in the model object does not matter as long as they are present. Spatial (or temporal) projections only make use of those predictors in the equation (formula).

from ibis.isdm.

mhesselbarth avatar mhesselbarth commented on May 30, 2024
  • It needs to pass on predictions among multiple steps. One can think of an example where like 3 or more different datasets are added.
  • Ultimately the number of predictors in the model object does not matter as long as they are present. Spatial (or temporal) projections only make use of those predictors in the equation (formula).

I understand that and it's done within the loop in train() as well as updating the formula object. My question is why in the code example above the extracted predictor values are added to the first data.frame which stores covariates a + b. Doesn't it only require c + d+ prev.prediction but NOT a + b + prev.prediction? For example, the first formula is also not updated using a skip, but the data.frame still is.

Even if its not particular used during any later predictions, it adds unnecessary to the data.

from ibis.isdm.

Martin-Jung avatar Martin-Jung commented on May 30, 2024

My question is why in the code example above the extracted predictor values are added to the first data.frame which stores covariates a + b. Doesn't it only require c + d+ prev.prediction but NOT a + b + prev.prediction?

If at some point we want project() to reproduce the formula of train() we would need all the predictors in the dataset (unless full models are saved in the object, which would be even larger in size than additional columns).

Even if its not particular used during any later predictions, it adds unnecessary to the data.

if you think it is critical to fix, and it does not affect the functionality of method_integration="predictor" , then feel free to commit a fix.

from ibis.isdm.

Martin-Jung avatar Martin-Jung commented on May 30, 2024

I think this can be closed due to #119 right?

from ibis.isdm.

mhesselbarth avatar mhesselbarth commented on May 30, 2024

I think so yes

from ibis.isdm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.