Giter Club home page Giter Club logo

Comments (6)

holta avatar holta commented on June 7, 2024

There is no good reason for any of us to keep manually renaming such images again and again. Is some script (or some person?) creating duplicate copies of all these images out of some misguided attempt to create backup copies? Or is there some other root cause for this completely unnecessary pattern making life difficult for everyone involved?

For whatever reason the KOC Uganda IIAB uses these images with long filenames:

  • en-catdogbooks_logo.png
  • en-mustardseedbooks_logo.png
  • en-openstax_OpenStaxLogo.jpeg

Which are the exact same images as contained in https://github.com/iiab/iiab-admin-console/tree/master/roles/js-menu/files/menu-files/images with short filenames here:

A script is apparently creating the .json outlines -> files below, perhaps directly from OER2Go.org metadata or such (is that script or similar what's in need of improvement?)

PR #213

from iiab-admin-console.

tim-moody avatar tim-moody commented on June 7, 2024

Auto generated files are not assumed to be accurate, but are expected to be edited, and they are not automatically added to the repo, and they do not overwrite existing files. They can only compute the logo name, and we don't currently try to download it. So I only see one en-catdogbooks.json which means someone changed or accepted the logo and someone added it to the repo.

Files added to the repo should be edited and tested, not just the text but the logo.

Not sure what the script should do different, though it could be responsible for the extra fields. I suppose it could try to find a similarly named image and call that the logo, but this will go wrong just as often and be harder to spot. It is not possible without AI to create accurate json files, but it is easier to change than to create.

from iiab-admin-console.

holta avatar holta commented on June 7, 2024

That helps explain what's happening behind the scenes, thanks:

Now where exactly do we find OER2Go's original name for these images?

i.e. probably best to stick with those names to avoid most/all such hassles?

from iiab-admin-console.

tim-moody avatar tim-moody commented on June 7, 2024

This sounds a lot easier than it is and will vary by module. First, since the catalog broke there are no logo names in it. Second, in the case of Cats and Dogs the name is logo.png, probably to make RACHEL navigation generation easier.

from iiab-admin-console.

holta avatar holta commented on June 7, 2024

What a mess.

Ok let's stick with the short names for now then.

Which at least means no renaming of images is required within https://github.com/iiab/iiab-admin-console/tree/master/roles/js-menu/files/menu-files/images

from iiab-admin-console.

holta avatar holta commented on June 7, 2024

Plz merge PR #221

from iiab-admin-console.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.