Screen fading rendering issues for Kingdom Overview about fheroes2 HOT 7 CLOSED

Hi, @zenseii, this is observed on any resolution and when closing Castle screen not from Kingdom overview. And this is the closest color for the current brightness value of image, returned by GetPALColorId(). We are limited to the color of game palette.
Maybe we should use ApplyTransform() instead ... (or modify GetPALColorId()). I'll check it later.

from fheroes2.

Hi, @zenseii, after the castle screen is closed the shadow of the dialog (to the left of dialog) becomes stronger.
And if I buy 4 heroes in 4 castles closing castle dialog every time, I'll get almost fully black shadow. :)

from fheroes2.

You can also dismiss a hero from Hero dialog to get the same result.

from fheroes2.

Hi @ihhub, what do you mean by abnormal rendering? :)
Kingdom overview and castle screen are opened in a "StandardWindow" (not full-screen), so after closing kingdom overview there is no fade-in animation.
The screen moves down after kingdom overview is closed because mouse pointer is near the bottom edge of game screen.

from fheroes2.

Hi, @Districh-ru. I believe what @ihhub refers to is the blue-ish colored effect that is sometimes visible for a split second when fading. Particularly visible on the horse/knight piece graphics:

from fheroes2.

There is a bug in Kingdom Overview: Open Castle, buy a Hero and go back to Kingdom Overview: there will be one more shadow added to the Kingdom Overview dialog.
https://user-images.githubusercontent.com/113276641/262657815-b209d4eb-40a1-4e63-88cf-71fce40d93d4.gif

It could be possibly a source of the small "hang" after closing the castle screen, shown in this issue.

from fheroes2.

There is a bug in Kingdom Overview: Open Castle, buy a Hero and go back to Kingdom Overview: there will be one more shadow added to the Kingdom Overview dialog. https://user-images.githubusercontent.com/113276641/262657815-b209d4eb-40a1-4e63-88cf-71fce40d93d4.gif

It could be possibly a source of the small "hang" after closing the castle screen, shown in this issue.

Hi, @Districh-ru
I'm not sure I see the extra shadow in the linked to gif? Where on the overview screen does it show up?

from fheroes2.