Giter Club home page Giter Club logo

Comments (1)

kailuowang avatar kailuowang commented on May 26, 2024

@benmccann thank you for adding to the swagger-play readme. It is a nice thing for users of swagger and play to have multiple alternatives.

1, Thanks for letting us know about the routes parser PR, we can definitely use that.
2, Personally I like play's routes DSL and our developers are more familiar to it than swagger spec.
IMHO play routes DSL is more concise than the swagger spec equivalent when providing the basic information, e.g.
controllers.GN.createCard(profileId: Int, contextName: String) v.s.

parameters: [
  { name: "profileId",
    type: "integer",
    format: "int32",
    required: true
  },
  { name: "contextName",
    type: "string",
    required: true
  }
]

So that's less work for adding swagger to an existing play app, especially when you don't need to add a bunch of extra information than what the routes files already provide. In most cases all they need to add is a description and a respond and/or a request body ref.

I'm also a little concern over the number of layers of code generation in that approach, a swagger spec generating routes file than generate java routes classes. Could be hard to debug.
3, this library uses runtime reflection to the get the arguments list of the main constructor. I am certain it won't work with POJOs that lack a constructor with all fields. Not sure the other case. (sorry my java is even weaker than my scala), but I don't think it will be too hard to enhance it to work with POJOs.

from play-swagger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.