Giter Club home page Giter Club logo

Comments (8)

lieuweberg avatar lieuweberg commented on August 24, 2024 1

Thank you so much! It worked! I can start properly making my app now, thanks again! =D

from electron-updater-example.

iffy avatar iffy commented on August 24, 2024

What version of electron-updater, electron-builder, and electron are you using? Also, what are you seeing?

from electron-updater-example.

lieuweberg avatar lieuweberg commented on August 24, 2024

Thanks for reaching out.

electron: 3.0.2
electron-updater: 3.1.2
electron-builder: 20.28.4

I'm just seeing my regular application. No pop-ups or anything else. This is how I defined my repo:

  "repository": {
		"type": "git",
		"url": "https://github.com/lieuwe-berg/timerapp.git"
  }

I see you didn't do that, so how does it recognize it on yours?

from electron-updater-example.

iffy avatar iffy commented on August 24, 2024

@lieuwe-berg Have you tried doing the steps in the README exactly? (Before adding your own code)

The latest versions I've tested with are:

  • electron 1.7.9
  • electron-updater 2.21.4
  • electron-builder 20.8.2

By default, it detects your GitHub settings looking at .git/config I think.

If I get some time, I'll try upgrading the dependencies of this repo to see if there are problems with newer versions (and if that explains what you're seeing)

from electron-updater-example.

lieuweberg avatar lieuweberg commented on August 24, 2024

That would be awesome, thanks!
I'll try the read.me exactly soon. I just didn't use your code before.

from electron-updater-example.

iffy avatar iffy commented on August 24, 2024

@lieuwe-berg I've just tested with the latest versions of things (electron 3.0.2, builder 20.28.4, updater 3.1.2) and it still works on this test repo. So we can rule that out.

from electron-updater-example.

lieuweberg avatar lieuweberg commented on August 24, 2024

How do you get it to find your github?

from electron-updater-example.

iffy avatar iffy commented on August 24, 2024

@lieuwe-berg by default electron-updater looks at stuff inside the .git folder to guess where the GitHub repo is. For instance, .git/config contains details about the origin remote. But you can explicitly set your GitHub repo as described in step 2 here: https://github.com/iffy/electron-updater-example/blob/master/README.md

from electron-updater-example.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.