Obtaining URL for Blog Post Pull Request? about 2024 HOT 6 CLOSED

In this example PR

#48

GitHub actions added a comment:

👋 Thanks for your submission! We have successfully built your website and we will push it shortly to the URL https://d2jud02ci9yv69.cloudfront.net/2024-05-07-works-48/blog/works/ !

I didn't receive anything like that for my PR. Might I have done something wrong?

from 2024.

I see a message: filter-files / Detect what files changed (pull_request) Skipped

Could this be the culprit?

from 2024.

Thanks for the report @RylanSchaeffer . I'm looking into it

from 2024.

Hi @RylanSchaeffer , and apologies for this hiccup. There should indeed be no modifications to other files other than your post. I see at least modifications to .gitignore, _layouts/distill.html (which I BTW just incorporated in the main repo, and _posts/2024-05-07-distill-example.md and _posts/2024-05-07-distill-example2.html , which should be left intact.

It's still odd that you didn't get an error message. We have a check that should have warned you of these issues (@Velythyl I suspect the issue was that the runs were only run if the PR had an assigned "Submission" tag, I changed it here 7507ec1 . Is there a reason why we should only run after we've set up the "Submission" tag?).

In any case, please update your pull request @RylanSchaeffer with the modifications mentioned above and let us know if it works

from 2024.

We were skipping PRs without the Submission tag to prevent our pipeline to run when we make our own hotfix/fixes/improvements/etc PRs. But I think we originally did that because the pipeline would auto-close failed PRs. Now that we don't autoclose, it's safe to run on all PRs, even without the Submission tag.

from 2024.

@RylanSchaeffer : it seems the issue has been fixed. I'll close this issue.

BTW, I just submitted a small fix that should fix some color issues I saw in your post with the dark theme (some math was appearing black). If you merge from master those problems should hopefully go away

from 2024.