Giter Club home page Giter Club logo

Comments (12)

IchHabRecht avatar IchHabRecht commented on August 24, 2024

Hi @kitzberger,

Thank you for your report. I just set up a test scenario on my dev system. Everything is working as expected for missing video/media files. Those files are already fetched properly from defined remote resources (using 'domain' or 'sys_domain' identifiers).

from filefill.

kitzberger avatar kitzberger commented on August 24, 2024

Sure, that's true! But in my case there's no remote system to fetch resources from. Hence the ascii handler. But OK, we'll run with our fork of your extension then ;-)

from filefill.

ayacoo avatar ayacoo commented on August 24, 2024

Hi, I'm running into this problem right now too. Do you have any idea how we can document this and what the specific questions would be? It is also the case with me that no remote system is used.

My question right now is: What would I need to set up to get online providers like Youtube/Vimeo/etc. working? Especially in case you don't have a remote system.

I would also offer a PR, am just undecided what is now the "official" way :-)

Btw: Of course I saw the discussion in PR :-)

from filefill.

IchHabRecht avatar IchHabRecht commented on August 24, 2024

Hi @ayacoo,

You can find proper documentation for own resource handler at https://github.com/IchHabRecht/filefill#additional-resources
What is your expectation regarding those media files without any remote?

from filefill.

ayacoo avatar ayacoo commented on August 24, 2024

@IchHabRecht Okay, if I understand it correctly you would leave out the AsciiHandler from the PR as well, right? At least that's what the closed pull request implies ;-)

Then my suggestion would be that under "Known issues" we mention the textfile handling including Youtube once and then refer to the resource handler place in the doc. Would that be ok?

And before I forget: The goal would be to prevent the error message "File not found". For example, a TYPO3 Youtube video can be set as default?

from filefill.

IchHabRecht avatar IchHabRecht commented on August 24, 2024

@ayacoo I still don't get your expectation yet

from filefill.

ayacoo avatar ayacoo commented on August 24, 2024

@IchHabRecht Okay, I try again :-)

Context: TYPO3 migration and no connection to a remote system. EXT:filefill is initialized with placeholder.com, so for images it works. When I call the page I get this error message.

PHP Warning: file_get_contents(/var/www/html/public/fileadmin/user_upload/[CUSTOM_FILENAME].youtube): failed to open stream:

What I'm missing now is any info on how to handle it as a newbie.

Variant A: Is apparently this pull request, which would integrate its own handling
Variant B: Maybe extend the documentation a bit to write this case. "Dear user: In case of Youtube/Vimeo videos and without remote system, please build a resource handler. You can find an example here:" Link to pull request or a simple example in the Readme file. For me, the connection between Additional resources and Youtube was not clear here.

I hope my request became a little clearer :-)

from filefill.

kitzberger avatar kitzberger commented on August 24, 2024

@IchHabRecht, give the people what they want ;-) No, seriously, it's a plain and simple change that could cover a lot of use cases. Just saying ;-)

from filefill.

IchHabRecht avatar IchHabRecht commented on August 24, 2024

@kitzberger I have concept for a more generic solution to cover all other files as well. Currently looking for some sponsoring to implement it. But as I already tried to explain, I don't think it is a common use case (for filefill) to set it up without any remote at all. This was never a concept I wanted to support. BTW: not all of us understand that kind of joke!
I already proposed to set up an addon-extension for those cases but obviously nobody wants to do that kind of job. So please respect that I decide what I want to support within my extension and what not.

from filefill.

ayacoo avatar ayacoo commented on August 24, 2024

For me that's okay, because you are the owner of the extension and you have to make the decisions. I will orient myself for my case on the basis of the PR and if someone is still looking for it, there are enough tips here how to deal with the case.

from filefill.

IchHabRecht avatar IchHabRecht commented on August 24, 2024

Hi @kitzberger @ayacoo
It would be really cool if you could test the attached merge request and give me some feedback if this is a proper way to solve your requirements.

from filefill.

kitzberger avatar kitzberger commented on August 24, 2024

@IchHabRecht, cool, solid feature I'd say ;-) Thanks a lot!

from filefill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.