DBPool creates 16 connections when incrementsSize = 10 about nodejs-idb-pconnector HOT 11 CLOSED

I’ll do that. Thanks for the help! From: Abdirahim Musse <[email protected]> Reply-To: IBM/nodejs-idb-pconnector <[email protected]> Date: Thursday, January 31, 2019 at 6:38 PM To: IBM/nodejs-idb-pconnector <[email protected]> Cc: Stephen Hildebrand <[email protected]>, Mention <[email protected]> Subject: Re: [IBM/nodejs-idb-pconnector] DBPool creates 16 connections when incrementsSize = 10 (#27) FYI, DBPool provides a prepare, bind, and execute helper: DBPool.prepareExecute()<https://github.com/IBM/nodejs-idb-pconnector#prepareexecute>. I would highly recommend using helper functions provided: * DBPool.runSql() * DBPool.prepareExecute() directly instead of recreating that functionality If you wanted to stick to using db_promise.js helper script I would only require DBPool within that file. So that you avoid creating unused connections. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#27 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/As3GM_cqZLnPjbRbUdwIxGcWTVqLQjxVks5vI35sgaJpZM4aUXbV>.

The job is submitted with the following environment variable ADDENVVAR ENVVAR(QIBM_QSH_CMD_OUTPUT) VALUE(‘FILEAPPEND=node _log.txt’) This is where I’m seeing the extra connections From: Abdirahim Musse <[email protected]> Reply-To: IBM/nodejs-idb-pconnector <[email protected]> Date: Thursday, January 31, 2019 at 4:59 PM To: IBM/nodejs-idb-pconnector <[email protected]> Cc: Stephen Hildebrand <[email protected]>, Mention <[email protected]> Subject: Re: [IBM/nodejs-idb-pconnector] DBPool creates 16 connections when incrementsSize = 10 (#27) The above statement creates 16 connections. Is this expected? @oneworks<https://github.com/oneworks> That is not expected, it should create 10 connections. I tried to recreate the issue with: const {DBPool} = require('idb-pconnector'); const pool = new DBPool({ url: "*LOCAL" }, { debug: true , incrementSize: 10}); console.log(`Pool contains: ${pool.connections.length} connections`); my output was Creating Connection 0... Connection 0 created Creating Connection 1... Connection 1 created Creating Connection 2... Connection 2 created Creating Connection 3... Connection 3 created Creating Connection 4... Connection 4 created Creating Connection 5... Connection 5 created Creating Connection 6... Connection 6 created Creating Connection 7... Connection 7 created Creating Connection 8... Connection 8 created Creating Connection 9... Connection 9 created Pool contains: 10 connections I'm only seeing 10 connections created. Are you redirecting stdout to a log file? When you have debug set to true then Creating connection output is printed at startup each time. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#27 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/As3GM2amB24CxhYtinvW9SPAH0MM8yQMks5vI2dMgaJpZM4aUXbV>.

You got me thinking…. I’ve created a helper script called db_promise.js const { DBPool } = require("idb-pconnector"); const pool = new DBPool({ url: "*LOCAL" }, { debug: true , incrementSize: 10}); var pdb = {}; pdb.query = async function(sql) { /* * Directly execute a statement by providing the SQL to the runSql() function. * NOTE: Stored Procedures must use the prepareExecute() method instead. */ try { return await pool.runSql(sql); } catch (error) { throw Error(error); } }; module.exports = pdb; Then in my express scripts I import it in. Turns out I had the DBPool here too. So, that was the issue. Apologies. Once I removed it, the log was correct. On a side note, is having an external DB helper script the optimal way to handle it? const express = require("express"); const app = express(); const router = express.Router(); const pdb = require("./db_promise"); const { DBPool } = require("idb-pconnector"); const pool = new DBPool({ url: "*LOCAL" }, { debug: true }); const dataLib = process.env.DATALIB; const commonLib = process.env.COMMONDATALIB; const surroundLib = process.env.SURROUNDDATALIB; const pgmLib = process.env.PROGRAMLIB; // Define routes // Get part lines from UDC 41/S1 router.post("/api/part/list/", function(req, res, next) { (async () => { try { let sql = "select trim(cast(drky as char(10) ccsid 37)) as LineId," + "drdl01 as LineDescription from " + commonLib + ".f0005 " + "WHERE DRSY = '41' and DRRT = 'S1' and DRDL02 <> ' ' order by drky"; let rs = await pdb.query(sql); if (rs.length > 0) { let prefix = '{ "Response":{ "Line":'; let newRS = prefix + JSON.stringify(rs) + ', "correlationID":"' + req.body.Header.correlationID + '","Tracking": { "isSuccess": "true" }}}'; res.writeHead(200, { "Content-Type": "application/json" }); res.status(200).end(newRS); } else { let rs = '{"Response": { "Line":' + "{" + '"correlationID":"' + req.body.Header.correlationID + '",' + '"Tracking":{' + '"isSuccess":"false",' + '"Fault":{' + '"code":"SF001",' + '"message":"No records found matching search criteria",' + '"stacktrace":""}}}}}'; res.writeHead(200, { "Content-Type": "application/json" }); res.status(200).end(rs); } } catch (err) { let rs = '{"Response": { "Line":' + "{" + '"correlationID":"' + req.body.Header.correlationID + '",' + '"Tracking":{' + '"isSuccess":"false",' + '"Fault":{' + '"code":"SF000",' + '"message":"' + err + '",' + '"stacktrace":""}}}}}'; res.writeHead(400, { "Content-Type": "application/json" }); res.status(400).end(rs); var d = new Date(); console.log("Query error: " + d.toLocaleString() + " " + err); } })(); }); Steve Hildebrand OneWorks Business Solutions, Inc. [email protected] 828-493-0096 From: Abdirahim Musse <[email protected]> Reply-To: IBM/nodejs-idb-pconnector <[email protected]> Date: Thursday, January 31, 2019 at 5:25 PM To: IBM/nodejs-idb-pconnector <[email protected]> Cc: Stephen Hildebrand <[email protected]>, Mention <[email protected]> Subject: Re: [IBM/nodejs-idb-pconnector] DBPool creates 16 connections when incrementsSize = 10 (#27) @oneworks<https://github.com/oneworks> Looks to me that output from your node app is being appended each time to that file. Seems like it was run twice. Creating Connection 0... Connection 0 created Creating Connection 1... Connection 1 created Creating Connection 2... Connection 2 created Creating Connection 3... Connection 3 created Creating Connection 4... Connection 4 created Creating Connection 5... Connection 5 created Creating Connection 6... Connection 6 created Connection 7 created Creating Connection 8... Connection 8 created Creating Connection 9... Connection 9 created Creating Connection 0... Connection 0 created Creating Connection 1... Connection 1 created Creating Connection 2... Connection 2 created Creating Connection 3... Connection 3 created Creating Connection 4... Connection 4 created Creating Connection 5... Connection 5 created Creating Connection 6... Connection 6 created Creating Connection 7... Connection 7 created What weird is that output ends after connection 7 was created. Is the above output the full log from the file? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#27 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/As3GM76ovbcPDboVwthaPhRZ7XFFWIrRks5vI21ugaJpZM4aUXbV>.

The helper will eventually have more things in it, for prepare, bind, etc. Thanks, Steve

I started thinking on this again… If I have, say 10 separate express route scripts, and each one had the following, wouldn’t each script create 10 connections? const { DBPool } = require("idb-pconnector"); const pool = new DBPool({ url: "*LOCAL" }, { debug: true, incrementSize: 10 }); Also, is there a way for idb-pconnector to return the variables as mixed case, as specified in the SQL? Currently, everything returns as all CAPS. From: Abdirahim Musse <[email protected]> Reply-To: IBM/nodejs-idb-pconnector <[email protected]> Date: Thursday, January 31, 2019 at 6:15 PM To: IBM/nodejs-idb-pconnector <[email protected]> Cc: Stephen Hildebrand <[email protected]>, Mention <[email protected]> Subject: Re: [IBM/nodejs-idb-pconnector] DBPool creates 16 connections when incrementsSize = 10 (#27) @oneworks<https://github.com/oneworks> In this case why not just use DBPool.runSql() directly within the post route? I think that would be more efficient and simpler than wrapping with the helper script. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#27 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/As3GM3zScdEG6LvMuGaxHzR-z_sJbMdQks5vI3kAgaJpZM4aUXbV>.