Giter Club home page Giter Club logo

Comments (4)

No9 avatar No9 commented on May 31, 2024

Hey @psact Thanks for the letting us know about this variant.
It's important for the project that we capture these scenarios.

Looks like an additional values override would cover this?
Something called values.aws.bottlerocket.yaml stored in https://github.com/IBM/core-dump-handler/tree/main/charts/core-dump-handler and containing the variables you set.

Also update the table in the chart README and we are good to go.
https://github.com/IBM/core-dump-handler/blob/main/charts/core-dump-handler/README.md#installing-the-chart

Edit:
As an aside I'm not sure how that is working for you as it seems to be setting the core dump location to be the docker socket?
If the change is to support a different container socket in CRIO I would have expected a change to be at .Values.daemonset.crioEndpoint

from core-dump-handler.

psact avatar psact commented on May 31, 2024

I had set crioEndpoint: "unix:///run/dockershim.sock", and deployCrioConfig: true which seemed to work. I kept the default dump mount location at /var/mnt/core-dump-handler

I went ahead and added some parameters for mounting the host docker socket, and pushed to my branch.

https://github.com/psact/core-dump-handler/tree/bottlerocket-dockersock

I can open a PR if you would like.

from core-dump-handler.

No9 avatar No9 commented on May 31, 2024

Ah now I understand - Thanks for clarifying and putting together the yaml file.
Happy to take this as a PR

from core-dump-handler.

No9 avatar No9 commented on May 31, 2024

Fixed in V8.6.1
Thanks again for the PR

from core-dump-handler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.