mq_prometheus: allow enable/disable status metrics separately about mq-metric-samples HOT 4 CLOSED

I don't think so.

Most of the code "above" the checking of the patterns makes sure we've got a clean response back to the main functions. While none of the current collectors do it, I can certainly imagine collectors that dynamically change the list of objects, and would rely on having that cleanup processing done between each iteration.

from mq-metric-samples.

If you don't set any object patterns, then no status queries should actually be made for that object type. eg

objects:
   channels:
   topics:

Functions like CollectChannelStatus would simply return immediately.

from mq-metric-samples.

Thanks for pointing that out @ibmmqmet,

I think I got it wrong because the patterns are checked after initializing everything else to perform status queries.

Would it make sense to move the check to the beginning of those functions?

from mq-metric-samples.

Thanks for the explanation.

from mq-metric-samples.