Error in `README` snippet. `RecipeTransform` vs `TransformResult` about ibis-ml HOT 3 CLOSED

@zilto Closing this because the API, including the code snippet, has changed. We will also try to add some end-to-end examples soon!

from ibis-ml.

@zilto Thanks for flagging! Good catch.

I don't know the motivations behind separating Recipe, RecipeTransform, and TransformResult. What raises questions is that both the transform and the train_fitted objects need to access train, but only the latter has .features and .outcomes set. Users coming from scikit-learn would expect 2 "layers" instead of 3 with Recipe (with a fitted: bool flag) and some sort of result.

I don't want to speak for him, but @jcrist is wrapping up a refactor that will reduce the "layers" in Ibis-ML. Hopefully some of this will resonate.

I can say that Ibis-ML was designed with intentional differences from scikit-learn (it's more tidymodels-inpired), but, again, @jcrist can definitely elaborate better on some of these points at this time, as the original author.

from ibis-ml.

Thanks for the context! I essentially opened issue to share the bug in the code snippet, so feel free to close the issue

from ibis-ml.