Giter Club home page Giter Club logo

Comments (3)

ibireme avatar ibireme commented on May 18, 2024

I haven't tested 32bit C++ compilation in CI, maybe there will be bugs.
I'll investigate later.

from yyjson.

ibireme avatar ibireme commented on May 18, 2024

@lnkuiper I tested many combinations of compile flags and failed to reproduce the bug, until I changed yyjson.c to yyjson.cpp and used the same flags from duckdb CI workflow.

The problem is with this combined flags: g++-5 -m32 -fPIC. When using these flags, both reader and writer test cases in yyjson will fail. But everything works fine if I use gcc-5 or a higher version of gcc/g++, or remove the -m32/-fPIC flag.

It seems that the __asm hint code in the read_number() function is causing the specific error. I removed this line of code in the latest version.

from yyjson.

lnkuiper avatar lnkuiper commented on May 18, 2024

@ibireme Fixing 32-bit bugs is the worst.

Thank you so much for taking the time to do this, and again thank you so much for this project!

from yyjson.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.