Consider returning NaN from yyjson_get_num about yyjson HOT 3 CLOSED

I wanted yyjson_get_xxx functions to return a default value (usually 0/NULL) on error. I get your point, but I’m not sure what most C developers would like from these functions. I checked some popular C JSON libraries and saw that cJSON returns NaN, while json-c, jansson, and parson all return 0. So I think returning 0 might be a better choice as it seems more common.

from yyjson.

Thanks for pointing out, I will remove the extra space later.

yyjson_get_num returns NaN is more reasonable indeed. But here it returns 0 just to be consistent with other functions like yyjson_get_int/yyjson_get_real/…

from yyjson.

That's a good point. Howewer, as I see it, yyjson_get_num is a high-level function over the yyjson_get_int/yyjson_get_real/… and does the conversions and returns only doubles, and NaN is perfect fit to indicate something is not a number in a world of doubles.

It's not a big deal anyway, considering that the type of value can always be checked for number manually prior to calling yyjson_get_num.

from yyjson.