Wrong read error about yyjson HOT 6 CLOSED

Thanks for your feedback~
I've fixed the incorrect error codes and added some test cases for them: 719b310

from yyjson.

Hi @ibireme ,

I have run into a similar issue again, this time with literals. If we read a JSON that has been cut off like this:

{"duck":tru

We get a YYJSON_READ_ERROR_LITERAL, but it should be YYJSON_READ_ERROR_UNEXPECTED_END. This is because the original pointer is not updated by the functions that read literals (e.g., true, false, inf, etc.). For example:

static_inline bool read_true(u8 **ptr, yyjson_val *val) {
    u8 *cur = *ptr;
    u8 **end = ptr;
    if (likely(byte_match_4(cur, "true"))) {
        val->tag = YYJSON_TYPE_BOOL | YYJSON_SUBTYPE_TRUE;
        *end = cur + 4;
        return true;
    }
    return false;
}

Should increment *ptr to where the error happens before returning false.

from yyjson.

@lnkuiper I think I understand your need now: a valid JSON truncated at any position should return exactly YYJSON_READ_ERROR_UNEXPECTED_END.

I just returned UNEXPECTED_END as a fallback before and didn't take care of this usage. So there is still some work to be done, especially to handle truncated unicode strings accurately.

from yyjson.

@ibireme exactly. I have a workaround that seems to work fine, so fixing this is not that important, but I thought I would report it anyway.

from yyjson.

I've fixed it by adding a new function that can detect whether a JSON that fails to parse is invalid, or valid but truncated: 8ffa6f5

I tested it with the JSONTestSuite dataset, and it seems to be working as expected.

from yyjson.

@ibireme This will help a lot with identifying problems when doing streaming JSON reads. Thank you so much!

from yyjson.