Comments (4)
Coverage with 2.7 release is at 6%.
Would it be useful for me to work on increasing Cocoadocs coverage for the Swift 3 release, or would other documentation be more useful ?
from ibanimatable.
@huntit Thanks, I think we have started adding more and more documentation comments in swift3
, the reason why the percentage has decreased for master branch because we have added a lot of ActivityIndicatorAnimation***
classes without documentation comments.
If we add some documentation comments for ActivityIndicatorAnimating
like
/// Protocol for all activity indicator classes.
public protocol ActivityIndicatorAnimating {
/**
Define the animation for the activity indicator.
- Parameter layer: The layer to execute the animation
- Parameter size: The size of the activity indicator.
- Parameter color: The color of the activity indicator.
*/
func configAnimation(in layer: CALayer, size: CGSize, color: UIColor)
}
It will improve a lot because the documentation comments will bring to all subclasses.
And we added some documentation comments to swift3
but didn't show up for 2.7 release. A good example is MaskDesignable
and MaskType
. please have a look at them. I think we don't need to add documentation comments to private
and fileprivate
methods.
Also, we have a quite comprehensive API document https://github.com/IBAnimatable/IBAnimatable/blob/master/Documentation/APIs.md . I think we can copy them in the code to create documentation comments. Then we don't need this file anymore.
I have sent out the invite to you for joining the IBAnimatable team. You can create feature branch in the IBAnimatable project directly when you work on that. Please have a look at our git process, IBAnimatable/IBAnimatableMaterial#1 , let me know if you have any questions.
from ibanimatable.
@JakeLin Thanks. Yes, coverage has increased to 21% now that I've got jazzy working locally on the Swift 3 branch. Once Xcode 8 goes RTM, Cocoadocs should update their version of jazzy for Swift 3 (support for open, fileprivate, etc). I'll have a look at your git process and start with doc comments for some of the protocols.
from ibanimatable.
@huntit thanks, good to know we are getting better. Our git process is very simple, just master and feature branches. no develop
and so on. please let me know if you have any questions.
from ibanimatable.
Related Issues (20)
- Chaining doesn't work at all HOT 1
- CALayerInvalidGeometry CALayer position contains NaN: [nan 11] HOT 1
- Accio installation fails HOT 3
- AnimatableModalViewController enable userInteraction on previous VC HOT 1
- Animations work without IB? HOT 2
- Update in to swift 5 HOT 1
- Animate rotate infinite? HOT 1
- SwiftUI integration / support HOT 2
- Module 'IBAnimatable' was not compiled with library evolution support HOT 1
- IBAnimatable with SPM & XCode 11 -> "currentMediaTime" unknown property HOT 1
- full view gradient (on main view) does not redraw upon screen orientation changing HOT 3
- Is there a mask which rounds certain selected sides? HOT 1
- Swift Package 6.0 compilation error HOT 7
- is there a mask for semicircle / cords? HOT 1
- CFBundleVersion issue while compiling demo code. How to resolve this issue?? HOT 4
- Image tint color for left and right textfield images.
- Button with IBAnimatable in iOS 14 title not display complete HOT 5
- Image going out of frame while apply shadow
- SPM Compiler Errors HOT 2
- <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> <plist version="1.0"> <dict> <key>CFBundleDevelopmentRegion</key> <string>en</string> <key>CFBundleExecutable</key> <string>$(EXECUTABLE_NAME)</string> <key>CFBundleIdentifier</key> <string>$(PRODUCT_BUNDLE_IDENTIFIER)</string> <key>CFBundleInfoDictionaryVersion</key> <string>6.0</string> <key>CFBundleName</key> <string>$(PRODUCT_NAME)</string> <key>CFBundlePackageType</key> <string>FMWK</string> <key>CFBundleShortVersionString</key> <string>0.5.0</string> <key>CFBundleSignature</key> <string>????</string> <key>CFBundleVersion</key> <string>$(CURRENT_PROJECT_VERSION)</string> <key>NSPrincipalClass</key> <string></string> </dict> </plist HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ibanimatable.