Giter Club home page Giter Club logo

Comments (4)

huntit avatar huntit commented on May 14, 2024

Coverage with 2.7 release is at 6%.
Would it be useful for me to work on increasing Cocoadocs coverage for the Swift 3 release, or would other documentation be more useful ?

from ibanimatable.

JakeLin avatar JakeLin commented on May 14, 2024

@huntit Thanks, I think we have started adding more and more documentation comments in swift3, the reason why the percentage has decreased for master branch because we have added a lot of ActivityIndicatorAnimation*** classes without documentation comments.

If we add some documentation comments for ActivityIndicatorAnimating like

/// Protocol for all activity indicator classes.
public protocol ActivityIndicatorAnimating {
  /**
   Define the animation for the activity indicator.

   - Parameter layer: The layer to execute the animation
   - Parameter size: The size of the activity indicator.
   - Parameter color: The color of the activity indicator.
   */
  func configAnimation(in layer: CALayer, size: CGSize, color: UIColor)
}

It will improve a lot because the documentation comments will bring to all subclasses.

And we added some documentation comments to swift3 but didn't show up for 2.7 release. A good example is MaskDesignable and MaskType. please have a look at them. I think we don't need to add documentation comments to private and fileprivate methods.

Also, we have a quite comprehensive API document https://github.com/IBAnimatable/IBAnimatable/blob/master/Documentation/APIs.md . I think we can copy them in the code to create documentation comments. Then we don't need this file anymore.

I have sent out the invite to you for joining the IBAnimatable team. You can create feature branch in the IBAnimatable project directly when you work on that. Please have a look at our git process, IBAnimatable/IBAnimatableMaterial#1 , let me know if you have any questions.

from ibanimatable.

huntit avatar huntit commented on May 14, 2024

@JakeLin Thanks. Yes, coverage has increased to 21% now that I've got jazzy working locally on the Swift 3 branch. Once Xcode 8 goes RTM, Cocoadocs should update their version of jazzy for Swift 3 (support for open, fileprivate, etc). I'll have a look at your git process and start with doc comments for some of the protocols.

from ibanimatable.

JakeLin avatar JakeLin commented on May 14, 2024

@huntit thanks, good to know we are getting better. Our git process is very simple, just master and feature branches. no develop and so on. please let me know if you have any questions.

from ibanimatable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.