Panic downloading video about lux HOT 4 CLOSED

@lamg I tried this:

annie -i -s 127.0.0.1:1080 -p https://www.youtube.com/watch\?v\=4FE79y_JkCE\&list\=PLGxuz-nmYlQMO2wRhUhV_g6AN3vLN_4X7

   Site:   YouTube youtube.com
  Title:   Graph Theory：64. Vertex Colouring
   Type:   video
Quality:   hd720
   Size:   63.57 MiB (66657987 Bytes)


   Site:   YouTube youtube.com
  Title:   Graph Theory：65. 2-Chromatic Graphs
   Type:   video
Quality:   hd720
   Size:   45.82 MiB (48050601 Bytes)

^C

but everything is normal here. Can you retry this to see it still wrong?

from lux.

The following code (from request.go) causes this error, is wrong because input/output errors shouldn't be treated as exceptional:

res, err := client.Do(req)
	if err != nil {
		log.Print(url)
		panic(err)
}

You should return the error value.

from lux.

You mean to ignore this error?

res, _ := client.Do(req)

But I don't understand why you got this Bad Gateway error

from lux.

I mean it shouldn't be treated as something worth of a panic call. Checkout the pattern I use for handling errors in https://github.com/lamg/pmproxy/blob/master/cmd/pmproxy/main.go. Every error in internal procedures is returned, the command line interface handles them at the end, because showing messages to the user is its concern.

The Bad Gateway probably is a consequence of using a very busy HTTP proxy server with little bandwidth for serving its clients.

from lux.