iand / moriarty Goto Github PK

It would be useful if Moriarty had a logging API, so that you could
optionally get log output from it.

Perhaps you could create a logging interface which would adapt existing log
frameworks (PEARL::Log, Zend_Log) so that Moriarty could log to them; the
default implementation could be a null logger, so that you get no log
output unless you configure a real logging back-end.

When SparqlServiceBase::get_query_params() sets $mime, the new value stays 
within the scope of that function.

Call by reference should be used.

I've attached a patch.

I get this output when running the tests

1) test_to_changeset(RollbackTest)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ -5,12 +5,15 @@
   <rdf:Description rdf:nodeID="cs1">
     <rdf:type
rdf:resource="http://purl.org/vocab/changeset/schema#ChangeSet"/>
     <ns0:subjectOfChange rdf:resource="http://example.org/#me"/>
-    <ns0:creatorName>Moriarty Rollback Class</ns0:creatorName>
-    <ns0:changeReason>Rollbacked Change, generated by Moriarty Rollback
Class</ns0:changeReason>
-    <ns0:addition rdf:nodeID="s1"/>
-    <ns0:addition rdf:nodeID="s2"/>
-    <ns0:removal rdf:nodeID="s3"/>
-    <ns0:removal rdf:nodeID="s4"/>
+    <ns0:removal rdf:nodeID="s1"/>
+    <ns0:removal rdf:nodeID="s2"/>
+  </rdf:Description>
+
+  <rdf:Description rdf:nodeID="cs2">
+    <rdf:type
rdf:resource="http://purl.org/vocab/changeset/schema#ChangeSet"/>
+    <ns0:subjectOfChange rdf:resource="http://example.org/#me"/>
+    <ns0:addition rdf:nodeID="s3"/>
+    <ns0:addition rdf:nodeID="s4"/>
   </rdf:Description>

 </rdf:RDF>
\ No newline at end of file

SimpleGraph::merge() is trying to use arrays and array keys without first 
checking to see if they are set.

I've attached a patch.

What steps will reproduce the problem?

1. Create a FacetService instance $f
2. Call $f->facet('blah', array('title', 'author'), 10) (NB fields passed
as an array).
3. Look at the request object attached to the response (doesn't really
matter what the response is).

What is the expected output? What do you see instead?

The query parameter on the querystring is composed of the fields you
passed, separated by spaces, rather than commas. So you don't get any results.

What version of the product are you using? On what operating system?

Using revision 44, but problem exists in HEAD; Linux

Sending a PUT request with the curlhttpclient doesn't work.

Here's a sample PHP script which demonstrates the bug:

<?php
// moriarty includes etc.

$content = "Hello world";
$mimetype = 'text/html';
$uri =
'http://api.talis.com/stores/prism-dev01/items/tenancies/cannerton/themes/1/file
s/header.html';
$credentials = new Credentials('user', 'pass');

$requestFactory = new HttpRequestFactory();
$request = $requestFactory->make('PUT', $uri, $credentials);
$request->set_body($content);
$request->headers['Content-Type'] = $mimetype;
$response = $request->execute();
?>

What is the expected output? What do you see instead?

Expect to see a PUT request to the Platform when tracing with wireshark;
instead, the request method isn't set at all, so gets treated as a get.

What version of the product are you using? On what operating system?

Revision 120, trunk

Please provide any additional information below.

Patch supplied below - just need to get the method from $request, not from
$this.

An example program which doesn't work (you need the Moriarty includes for
changesetbatch.class.php at the top, of course):

///////////////////
$rdf = '
<rdf:RDF
    xmlns:j.0="http://foo.com#"
    xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" > 
  <rdf:Description rdf:about="http://bar.com/items/69229">
    <j.0:MainTitle>some title</j.0:MainTitle>
</rdf:RDF>
';

$cs = new ChangeSetBatch(array('before' => $rdf, 'after' => array()))

echo $cs->to_rdfxml();
///////////////////

I expected to see this:

<?xml version="1.0" encoding="UTF-8"?>
<rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
  xmlns:ns0="http://purl.org/vocab/changeset/schema#">

  <rdf:Description rdf:nodeID="cs0">
    <rdf:type rdf:resource="http://purl.org/vocab/changeset/schema#ChangeSet"/>
    <ns0:subjectOfChange rdf:resource="http://bar.com/items/69229"/>
    <ns0:createdDate>2009-06-05T13:05:47+01:00</ns0:createdDate>
    <ns0:creatorName>Talis ChangeSet Builder plugin</ns0:creatorName>
    <ns0:changeReason>Change using Talis ChangeSet Builder
plugin</ns0:changeReason>
    <ns0:removal rdf:nodeID="Remove1"/>
  </rdf:Description>

  <rdf:Description rdf:nodeID="Remove1">
    <rdf:type
rdf:resource="http://www.w3.org/1999/02/22-rdf-syntax-ns#Statement"/>
    <rdf:subject rdf:resource="http://bar.com/items/69229"/>
    <rdf:predicate rdf:resource="http://foo.com#MainTitle"/>
    <rdf:object>some title</rdf:object>
  </rdf:Description>

</rdf:RDF>

but saw this instead:

<?xml version="1.0" encoding="UTF-8"?>
<rdf:RDF xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#">



</rdf:RDF>

Note that this is not because an empty array was used for 'after': it's
just that the __init() method isn't called automatically when you
instantiate the class; and the ARC2_IndexUtils plugin isn't part of the
Moriarty distribution.

Attached is a patch against trunk, revision 80.

It would be useful if Moriarty responses contained a property for the time
(in milliseconds) taken between initiating a Platform request and receiving
the response.

Index query doesn't necessarily exist in paget_abstractresource.class.php line 
38.

I've attached a patch.

Paget's ResourceDescription:map_uri() is not called.

I think this is actually a bug for paget, however, I couldn't find an 
appropriate place to call map_uri() from paget. Is there?

The attached patch is a quick fix to make sure that s,p,o are mapped right 
before they are added to the index in SimpleGraph::_add_arc2_triple_list()

What steps will reproduce the problem?

1. Create a Store object with Credentials passed into its constructor,
pointing at a Platform store which doesn't require authentication for
SPARQL queries
2. Get the sparql service from the Store object
3. Run a SPARQL query using the SparqlService's query() method

What is the expected output? What do you see instead?

Expected my query to run and return a 200.

However, because the Store object has authentication, this is passed on to
the SPARQL service; but if the store you're querying is open to the public,
the first request from moriarty (expecting a Digest auth header) instead
gets a 400 response from the Platform. (The POST body is not included in
the first request, as it's just being sent to get the digest.)

What version of the product are you using? On what operating system?

revision 59 of moriarty, PHP 5.2.6, curl 7.18.2, on Ubuntu Linux