App crashes when the users changes the lock screen pattern about secured-preference-store HOT 12 CLOSED

This seems to be somewhat related to #2 I'll test it thoroughly when I can manage some time and let you know.

from secured-preference-store.

@nirvik66 This is related to #2. The issue should not be there on API level 21 and upper.

from secured-preference-store.

@iamMehedi I need to support API level 18 so I modified your classes to added some logic to recover from the key store loss. Basically removing all alias in the keystore and clearing the SecuredPreferenceStore and regenerating everything. Let me know if you're interested.

from secured-preference-store.

@nirvik66 I'd like to take a look at the changes you've made. May be we can add that behavior as an optional migration/recovery policy to the library.

from secured-preference-store.

@iamMehedi I forked your project and I created a new branch with the changes. https://github.com/nirvik66/Secured-Preference-Store/tree/feature/fix-keystore-key-loss

You can see all the changes on the last commit on the branch but mainly,

On Encryption Manager:

• Removed all mentions about KeyProperties
• Change the logic of generateRSAKeys
• Added some methods to clear the keystore alias

On SecuredPreferencesStore:

• Save a new key to be able to determine if the key we have on the keystore is good to decrypt the values
• Modify the getSharedInstance to clear everything if the key is no longer valid

from secured-preference-store.

@nirvik66 Did your solution fix the crashes that happened because of this? Is it stable?

from secured-preference-store.

@mcassiano The reason for the crashes are still there (Google hasn't changed the way keystore works), but the library has a way to recover(start over, so the app doesn't crash). See here
https://github.com/iamMehedi/Secured-Preference-Store#recovery

from secured-preference-store.

@iamMehedi yes, I'm aware. I was just wondering if her solution is stable enough so I can use her branch. Thanks :)

from secured-preference-store.

@iamMehedi btw, I think I missed something. You need to explicitly set the DefaultRecoveryHandler if you want this behavior, right?

from secured-preference-store.

yes, you need to explicitly set that.

from secured-preference-store.

@iamMehedi got it! thanks. :)

from secured-preference-store.

@mcassiano Hey, sorry for the delay! I created that branch before the library implemented the recovery mechanism. Now, I wouldn't use my fork, it's better to use the library!

from secured-preference-store.