Comments (7)
Good catch. It shouldn't be like that. Do you have any ideas @zenangst ?
from lightbox.
I can have a look at this!
from lightbox.
I'm experiencing the exact same issue, given the exact same setup as the OP.
I believe the issue is that every time remoteImageDidLoad is called (PageViewDelegate method in LightboxController), loadDynamicBackground(image) is called as well. I think the dynamic background should only be updated when the image you're looking at is updated?
Thanks & I appreciate the hard work guys!
from lightbox.
@heisen273 @andrewbellay hey guys, I just made a small PR to fix this issue. Could you guys try the improve/dynamic-background
branch to see if that helps?
from lightbox.
@zenangst - This fixed the issue for me! thanks
from lightbox.
@andrewbellay glad to hear it mate, I'll get one of my co-workers to review it and when it is merged we can make a new sparkling release for you guys, cheers
from lightbox.
@andrewbellay @zenangst thank you, iOS Lords, really appreciate this!
from lightbox.
Related Issues (20)
- Strat with specific index HOT 5
- Swipe Delegate HOT 1
- Close Programmaticly HOT 3
- Delete image HOT 3
- RTL SUPPORT HOT 1
- Images in fullscreen cover the close button, delete and page count
- Blank screen if media failed to load. HOT 1
- Animated GIF Support HOT 2
- Playing local videos not working.
- Feature Request: Please provide GIF support
- Installation with SPM fails HOT 1
- Delete Item Notification
- Multiple images and video in the array loop
- Presenting LightBoxController doesn't work. HOT 1
- replace imaginary with kingfisher library HOT 3
- this is cannot play youtube URL 😔 HOT 2
- LightBox won't resolve in SPM HOT 2
- Authentication Headers
- Download button HOT 7
- Development question HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightbox.